Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an interface for KafkaError 📛 #87

Open
clvacher opened this issue Sep 6, 2023 · 0 comments
Open

Implement an interface for KafkaError 📛 #87

clvacher opened this issue Sep 6, 2023 · 0 comments
Labels
enhancement This issue or pull request improves a feature

Comments

@clvacher
Copy link
Collaborator

clvacher commented Sep 6, 2023

Problem

Currently the KafkaError is an Avro object, meaning that anyone using this library needs to have a schema registry on their cluster and use it.

Suggestion

We can create an interface KafkaErrorInterface that requires getters and setters for topic, partition, offset, error stack, message, with the default implementation being the KafkaError avro POJO.
Override could be declared in the properties just like ExceptionHandlers for KafkaStreams.

Alternatives Considered

We could also create a model and their serdes for all 3 main ways of interacting with kafka (Avro, JSON & Protobuff)

@clvacher clvacher added the enhancement This issue or pull request improves a feature label Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue or pull request improves a feature
Projects
None yet
Development

No branches or pull requests

1 participant