Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries on exception handler #34

Open
loicgreffier opened this issue Jun 23, 2023 · 1 comment
Open

Add retries on exception handler #34

loicgreffier opened this issue Jun 23, 2023 · 1 comment
Assignees
Labels
expert Expert difficulty level feature This issue adds a new feature

Comments

@loicgreffier
Copy link
Collaborator

Some production error or deserialization error can be retriable.

The production error handler and the deserialization error handler should handle these errors.

@loicgreffier loicgreffier added feature This issue adds a new feature expert Expert difficulty level labels Jun 23, 2023
@mlmomplot mlmomplot self-assigned this Jun 23, 2023
@mlmomplot
Copy link
Collaborator

mlmomplot commented Dec 1, 2023

@loicgreffier I am thinking for deserialization this issue is corrected by this PR : #75

For production, I think we check if the exception is retriable.

BUT, linked to the issue: how to treat InvalidPidMappingException? when we have that the record is not produced. If we catch it into the production exception handler and return ProductionExceptionHandlerResponse.FAIL, the stream is restarted, a new producer id and a new transactional is assigned, and the stream re-attempt to produce. We can discuss about it during a meeting 😉 and may be open the debate on other Invalid Exception like InvalidProducerEpochException 😉

@mlmomplot mlmomplot reopened this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
expert Expert difficulty level feature This issue adds a new feature
Projects
None yet
Development

No branches or pull requests

2 participants