Correcting DLS readings for orientations

[ComteDeLooz]

Dear,

In Tutorial 3 (DLS Sensor Basic Usage) under the part "Correcting DLS readings for orientations", there is written:
dls_irr = untilted_direct_irr * (percent_diffuse + np.cos (solar_elevation))

Is it possible in the last term, np.cos (solar_elevation) should be replaced by np.cos (np.pi/2 - solar_elevation)?

The solar_elevation is taken from PySolar (altitude) and this is referred to the horizontal plane while for the correction, I think an angle referred to zenith is supposed. Otherwise, the lower the sun is (i.e. lower altitude), the higher the computed irradiance on the ground will be.

Maybe I am missing something here. In both cases, it is meaningful for me to have this solved/explained.

Many thanks!

[poynting]

Hi @ComteDeLooz, good catch. You are correct, we should use sin(solar_elevation) to correct the direct irradiance to the flat-surface irradiance. I have committed a fix for this.

Cheers,

Justin