Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicts with Symfony Deprecation detector #9

Closed
mglaman opened this issue Mar 20, 2019 · 7 comments
Closed

Conflicts with Symfony Deprecation detector #9

mglaman opened this issue Mar 20, 2019 · 7 comments

Comments

@mglaman
Copy link
Owner

mglaman commented Mar 20, 2019

In debugging at MidCamp we had issues where the tool would not run. The site had Symfony Deprecation Detector which was requiring 3.1

@mglaman
Copy link
Owner Author

mglaman commented Mar 20, 2019

This was caused by acquia/blt and it no longer ships with sensiolabs-de/deprecation-detector in v10.

See: acquia/blt@4fe4cbe

@josephdpurcell
Copy link
Collaborator

To be clear -- the issue was caused when running a Drupal project with BLT 9.

@mikemadison13
Copy link

We will be removing sensiolabs-de/deprecation-detector from BLT 9.2.x in the very near future, see acquia/blt#3621

@JDDoesDev
Copy link

@mikemadison13 I've read through that thread and others and that PR seems to need quite a bit of work. Can you elaborate on when "the very near future" may be?

@mikemadison13
Copy link

@JDDoesDev it's pretty high on my priority list, so in the next couple of days. i don't think removing it will be terribly hard, since BLT 10x doesn't have an analog to this feature (we'll just be removing it outright from 9.2.x). We may "re-add" something else in the future, but my hope is to yank this out so people can start doing the deprecation scans ASAP.

@JDDoesDev
Copy link

@mikemadison13 acquia/blt#3546 seems to be a good place to meet in the middle so that people still have a command line option and aren't tied to the UI. This is definitely a BLT problem and not drupal-check problem.

@mikemadison13
Copy link

FYI the fix is up in a PR on BLT's queue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants