Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated constants not recognized #89

Closed
1 of 4 tasks
mortenson opened this issue Jun 16, 2019 · 2 comments
Closed
1 of 4 tasks

Deprecated constants not recognized #89

mortenson opened this issue Jun 16, 2019 · 2 comments
Labels
phpstan-deprecation-rules Issue related to the Deprecation Rules extension

Comments

@mortenson
Copy link

How is drupal-check installed?

  • drupal-check is installed using the phar
  • drupal-check is installed globally via Composer
  • drupal-check is installed globally using consolidation/cgr
  • drupal-check is installed as a dependency to my project

Environment:

  • OS: macOS
  • PHP Version: 7.2.15
  • Drupal core: 8.7.x

Describe the bug
From my experience this tool can't pick up deprecated constant usages, for example if one of the FILE_ constants is used the tool doesn't say there's any deprecated code usage. This may result in people moving to the file_system service without replacing their use of file constants.

Console output
Not applicable.

@mglaman mglaman added the phpstan-deprecation-rules Issue related to the Deprecation Rules extension label Jun 24, 2019
@mglaman
Copy link
Owner

mglaman commented Jun 24, 2019

See mglaman/phpstan-drupal#58

@goba
Copy link
Sponsor

goba commented Dec 11, 2019

mglaman/phpstan-drupal#58 was closed yesterday with a hardcoded list of constants for now. IMHO this should be closed too.

@mglaman mglaman closed this as completed Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
phpstan-deprecation-rules Issue related to the Deprecation Rules extension
Projects
None yet
Development

No branches or pull requests

3 participants