Function libraries_get_path() not found

[Sergey-Orlov]

I'm using CKEditor with some contrib plugins.

And some of them have next construction in code of plugin:

  /**
   * Get path to library folder.
   */
  public function getLibraryPath() {
    $path = 'libraries/colorbutton';
    if (\Drupal::moduleHandler()->moduleExists('libraries')) {
      $path = libraries_get_path('colorbutton');
    }

    return $path;
  }

For example:

• Colorbutton
• Panelbutton
• Bootstrap Glyphicon
• Color Dialog
• CKEditor Bootstrap Buttons

If I don't have libraries module in the project, I got next error from drupal-check:
Function libraries_get_path not found.

I have tried to add function_exists() condition there, but it doesn't help.

Is there any way to pass such cases? Cause I see no issue in code.

[mglaman]

Yeah, there are problems with analyzing modules which use other modules. Drupal Commerce provides a Panelizer plugin and that freaks out.

There would have to be tricks done in phpstan-drupal to support this. I'm going to leave this open for others to find. I can't think of a straight forward fix beyond "ensure dev dependencies are installed"

[andypost]

Maybe there's a way to provide "exclude" config?

[mglaman]

In my opinion, should have all of your development dependencies when running static analysis. What if you had code within moduleExists or function_exists that uses deprecated code or bad method calls? It feels like too much work to fight this problem versus ensuring all conditional dependencies for conditional support are available.

[andypost]

I'm happy to see such "weak dependencies" are caught by analysis! if module require external library it must declare it, otoh sadly there's no strong opinion in https://www.drupal.org/project/drupal/issues/2873160

[mglaman]

I'm going to close this. I see this as "works as designed" because it is forcing the analysis of your code in its entirety.