Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixability grade to the deprecations output #79

Closed
goba opened this issue Jun 2, 2019 · 2 comments
Closed

Add fixability grade to the deprecations output #79

goba opened this issue Jun 2, 2019 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@goba
Copy link
Sponsor

goba commented Jun 2, 2019

In http:https://hojtsy.hu/blog/2019-may-24/analysis-top-uses-deprecated-code-drupal-contributed-projects-may-2019 I graded each deprecation into 4 categories:

  1. Don't know
  2. Only in dev version of core (should not be fixed yet)
  3. In supported version of core (should be fixed for custom code, not for d.o projects)
  4. In unsupported version of core (should be fixable, unless you have a really old core)

Now that phpstan provides the deprecation version number in the output, we can grade each one automatically. Especially once https://www.drupal.org/project/drupal/issues/3048498 is fixed this grading will become even more accurate.

Solution probably should not be in drupal-check, but some layer above it so other consumers of the libraries can use it. Eg. Upgrade status, the d.o drupalci integration, etc.

@goba
Copy link
Sponsor Author

goba commented Jun 2, 2019

The processing / result is a bit more complicated when you encounter contrib projects deprecating things and/or 3rd party dependencies doing the same, so those should be put in the "don't know" category IMHO.

@mglaman mglaman added this to Needs Research in Issue triage Jun 12, 2019
@goba
Copy link
Sponsor Author

goba commented Jun 27, 2019

This has now been implemented in the dev version of Upgrade Status. 5 categories I came up with:

  1. Ignore: deprecations to be removed for Drupal 10, ignore for now.
  2. Later: deprecation to be acted on later (in supported core version for a contrib module, in a later version than the core you are using for custom modules).
  3. Safe: in the version or an older version than your core for custom modules.
  4. Old: deprecation in older unsupported core version (for contributed modules).
  5. Uncategorized: for everything else, eg. random PHP errors.

I made the listing add a legend for the ones encountered in the concrete list.

Screenshot 2019-06-27 at 17 20 23

@mglaman mglaman added enhancement New feature or request help wanted Extra attention is needed labels May 11, 2020
@mglaman mglaman closed this as completed Feb 4, 2022
Issue triage automation moved this from Needs Research to Closed Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Issue triage
  
Closed
Development

No branches or pull requests

2 participants