Is it possible to check for use of deprecated classes?

[FatherShawn]

So I ran this on one of my contrib modules:

drupal-check docroot/modules/formassembly
 27/27 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


 [OK] No errors

But I know that I have overridden constructors populating parameters with deprecated services, such as:

class FormAssemblyEntityViewBuilder extends EntityViewBuilder {

  ...

  /**
   * {@inheritdoc}
   */
  public function __construct(
    EntityTypeInterface $entity_type,
    EntityManagerInterface $entity_manager,
    LanguageManagerInterface $language_manager,
    Registry $theme_registry = NULL,
    ApiMarkup $markup,
    LoggerInterface $loggerChannel,
    KillSwitch $killSwitch
  ) {
    parent::__construct($entity_type, $entity_manager, $language_manager,
      $theme_registry);
    $this->markup = $markup;
    $this->logger = $loggerChannel;
    $this->killSwitch = $killSwitch;
  }
}

phpStorm lines out EntityManagerInterface and I learned at DruaplCon and via Slack from Alex Pott that this should be refactored to drop the constructor entirely, putting the custom service population in create() Can we catch instantiation or passing of deprecated objects in addition to deprecated methods?

[mglaman]

Ah, interesting. This definitely needs to be moved to phpstan-drupal. Or kept here and a mirror opened (I need to decide how I want to manage that.)

The root detection is phpstan-deprecation-rules. The investigation would need to check there for passing deprecated classes into a constructor.

[mglaman]

See mglaman/phpstan-drupal#321 as well

[FatherShawn]

So should this issue be in mglaman/phpstan-drupal ??

[mglaman]

This got fixed a while ago in phpstan-drupal