drupal-check fails when some modules exist

[adamfranco]

I found that having the examples module installed in a Drupal instance (even if not enabled) will cause drupal-check to fail with an opaque error and no other output:

\Drupal::$container is not initialized yet. \Drupal::setContainer() must be called with a real container.

This can be replicated by creating brand-new install of Drupal built via the composer command in the readme, then installing the examples module with composer before running drupal-check:

composer create-project drupal-composer/drupal-project:8.x-dev drupal --no-interaction --stability=dev
cd drupal
composer require 'drupal/examples:1.x-dev'
drupal-check ./

Here is a portion of the backtrace where the exception was being generated:

#0  Drupal::getContainer() called at [/home/afranco/drupal/web/core/lib/Drupal.php:159]
#1  Drupal::service(extension.list.module) called at [/home/afranco/drupal/web/core/includes/bootstrap.inc:241]
#2  drupal_get_filename(module, tabledrag_example) called at [/home/afranco/drupal/web/core/includes/bootstrap.inc:293]
#3  drupal_get_path(module, tabledrag_example) called at [/home/afranco/drupal/web/core/includes/module.inc:134]
#4  module_load_include(inc, tabledrag_example, tabledrag_example.data) called at [/home/afranco/drupal/web/modules/contrib/examples/tabledrag_example/tabledrag_example.install:14]
#5  require(/home/afranco/drupal/web/modules/contrib/examples/tabledrag_example/tabledrag_example.install) called at [/home/afranco/.composer/vendor/mglaman/drupal-check/vendor/mglaman/phpstan-drupal/src/Drupal/Bootstrap.php:100]
#6  PHPStan\Drupal\Bootstrap->register() called at [/home/afranco/.composer/vendor/mglaman/drupal-check/vendor/mglaman/phpstan-drupal/phpstan-bootstrap.php:3]
#7  require_once(/home/afranco/.composer/vendor/mglaman/drupal-check/vendor/mglaman/phpstan-drupal/phpstan-bootstrap.php) called at [/home/afranco/.composer/vendor/mglaman/drupal-check/vendor/phpstan/phpstan/src/Command/CommandHelper.php:209]
#8  PHPStan\Command\CommandHelper::PHPStan\Command\{closure}(/home/afranco/.composer/vendor/mglaman/drupal-check/vendor/mglaman/phpstan-drupal/phpstan-bootstrap.php) called at [/home/afranco/.composer/vendor/mglaman/drupal-check/vendor/phpstan/phpstan/src/Command/CommandHelper.php:210]
#9  PHPStan\Command\CommandHelper::begin(Symfony\Component\Console\Input\ArgvInput Object ([Symfony\Component\Console\Input\ArgvInputtokens] =>

While drupal-check can't be responsible for all modules, it would be helpful to at least catch exceptions in the Bootstrap process and output a message indicating which module or theme is the offending one.

[adamfranco]

It looks like this is related to the fix for mglaman/phpstan-drupal#51, but that one doesn't seem to cover the .install files.

[mglaman]

The problem is this line in the .install file.

/**
 * Loads the basic data to be stored for all tabledrag examples.
 */
module_load_include('inc', 'tabledrag_example', 'tabledrag_example.data');

I may need to tag a new phpstan-drupal release.

[mglaman]

The problem is definitely in the .install file for tabledrag_example

[prudloff-insite]

Hello,
I am getting a similar error when realistic_dummy_content is installed:

\Drupal::$container is not initialized yet. \Drupal::setContainer() must be called with a real container.

If I remove this module, I don't get this error anymore.

[mglaman]

This will be fixed in 1.0.10 to not be a hard failure.

[mglaman]

Releasing 1.0.10 shortly, please test. It should recover this error and just print it.

[prudloff-insite]

I confirm this is fixed in 1.0.10, thanks!

[adamfranco]

I can confirm this is fixed in 1.0.10 as well. Thanks!