Document working around conflicts of nikic/php-parser:~3

[mglaman]

Drush requires psy which allows v2, v3, v4 of php parser. The problem is a Drupal site may have v3 installed because there is no hard requirement.

After research, this seems to be a legacy problem for sites that were set up before the v4 branch was opened. We need to find a decent workaround beyond "well, remove composer.lock and the vendor directory for your project"

PHP-Parser 4.0.0 on Feb 28, 2018

This means any Drupal 8 project created before Drupal 8.5.0 (7 Mar 2018) probably has the v3 branch of the PHP-Parser.

Drupal Check can probably do some detection against that Drupal project and provide helpful information for a solution.

[mglaman]

This relates to phpstan/phpstan#1386

[andypost]

Makes sense to suggest using php-ast extension

[mglaman]

But then we'd require people to install the extension, and I don't know if PHPStan supports php-ast :/

[andypost]

looks I mixed it with phan, sorry

[mglaman]

Here is the root problem: mglaman/phpstan-drupal#57

[mglaman]

What is weird is that this passed: https://circleci.com/gh/mglaman/drupal-check/78

A fresh project installed the right version.

Installing nikic/php-parser (v4.2.1): Loading from cache

[JDDoesDev]

In case anyone is searching for this exact error, but unable to get to it, the error that got me here is call to member function isSpecialClassName() on string

[JDDoesDev]

This issue is also part of Acquia BLT generated sites. BLT 9.2 requires sensiolabs-de/deprecation-detector which has a requirement for nikic/php-parser:~3.0

[JDDoesDev]

Here's a workaround that we're using:

https://www.jamesdflynn.com/development/drupal-check-site-factory-and-acquia-blt-oh-my

[mglaman]

The latest versions use PHPStan 0.12, which namespaces its dependencies. This prevents namespace clashes like this. I'll close for now.