Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

running on dgo.to/xhprof causes fatal error #3

Closed
andypost opened this issue Feb 26, 2019 · 2 comments
Closed

running on dgo.to/xhprof causes fatal error #3

andypost opened this issue Feb 26, 2019 · 2 comments

Comments

@andypost
Copy link

Did not check deeper but log is

core8$ drupal-check.phar -d -vvv modules/XHProf/
Performing deprecation checks
Current working directory: /home/andypost/www/core8
Using Drupal root: /home/andypost/www/core8
Using vendor root: /home/andypost/www/core8/vendor
Using autoloader: /home/andypost/www/core8/vendor/autoload.php
PHPStan crashed in the previous run probably because of excessive memory consumption.
It consumed around 26 MB of memory.


To avoid this issue, allow to use more memory with the --memory-limit option.
/home/andypost/www/core8/modules/XHProf/xhprof.drush.inc
/home/andypost/www/core8/modules/XHProf/modules/xhprof_mongodb/MongodbXHProfRuns.inc
/home/andypost/www/core8/modules/XHProf/modules/xhprof_mongodb/xhprof_mongodb.module
/home/andypost/www/core8/modules/XHProf/src/StorageFactory.php
/home/andypost/www/core8/modules/XHProf/src/Routing/RunConverter.php
/home/andypost/www/core8/modules/XHProf/src/ProfilerInterface.php
/home/andypost/www/core8/modules/XHProf/src/Form/ConfigForm.php
/home/andypost/www/core8/modules/XHProf/src/DataCollector/XHProfDataCollector.php
/home/andypost/www/core8/modules/XHProf/src/Compiler/StoragePass.php
/home/andypost/www/core8/modules/XHProf/src/XhprofServiceProvider.php
/home/andypost/www/core8/modules/XHProf/src/RequestMatcher/XHProfRequestMatcher.php
/home/andypost/www/core8/modules/XHProf/src/EventSubscriber/XHProfEventSubscriber.php
/home/andypost/www/core8/modules/XHProf/src/Profiler.php
/home/andypost/www/core8/modules/XHProf/src/Extension/UprofilerExtension.php
/home/andypost/www/core8/modules/XHProf/src/Extension/TidewaysXHProfExtension.php
/home/andypost/www/core8/modules/XHProf/src/Extension/TidewaysExtension.php
/home/andypost/www/core8/modules/XHProf/src/Extension/ExtensionInterface.php
/home/andypost/www/core8/modules/XHProf/src/Extension/XHProfExtension.php
/home/andypost/www/core8/modules/XHProf/src/Controller/XHProfController.php
/home/andypost/www/core8/modules/XHProf/src/XHProfLib/Parser/BaseParser.php
/home/andypost/www/core8/modules/XHProf/src/XHProfLib/Parser/Parser.php
/home/andypost/www/core8/modules/XHProf/src/XHProfLib/Parser/ParserInterface.php
/home/andypost/www/core8/modules/XHProf/src/XHProfLib/Parser/DiffParser.php
/home/andypost/www/core8/modules/XHProf/src/XHProfLib/Parser/SymbolsSorter.php
/home/andypost/www/core8/modules/XHProf/src/XHProfLib/Symbol/Symbol.php
/home/andypost/www/core8/modules/XHProf/src/XHProfLib/Aggregator.php
/home/andypost/www/core8/modules/XHProf/src/XHProfLib/Report/ReportEngine.php
PHP Fatal error:  Class Drupal\xhprof\XHProfLib\Report\DiffReport contains 6 abstract methods and must therefore be declared abstract or implement the remaining methods (Drupal\xhprof\XHProfLib\Report\ReportInterface::getSymbols, Drupal\xhprof\XHProfLib\Report\ReportInterface::getSummary, Drupal\xhprof\XHProfLib\Report\ReportInterface::getTotals, ...) in /home/andypost/www/core8/modules/XHProf/src/XHProfLib/Report/DiffReport.php on line 8

Fatal error: Class Drupal\xhprof\XHProfLib\Report\DiffReport contains 6 abstract methods and must therefore be declared abstract or implement the remaining methods (Drupal\xhprof\XHProfLib\Report\ReportInterface::getSymbols, Drupal\xhprof\XHProfLib\Report\ReportInterface::getSummary, Drupal\xhprof\XHProfLib\Report\ReportInterface::getTotals, ...) in /home/andypost/www/core8/modules/XHProf/src/XHProfLib/Report/DiffReport.php on line 8
@mglaman
Copy link
Owner

mglaman commented Mar 8, 2019

Seems like a legit bug in XHProfLib

Fatal error: Class Drupal\xhprof\XHProfLib\Report\DiffReport contains 6 abstract methods and must therefore be declared abstract or implement the remaining methods

@mglaman
Copy link
Owner

mglaman commented Mar 20, 2019

Yeah, the problem is in the code:

<?php

namespace Drupal\xhprof\XHProfLib\Report;

/**
 * Class DiffReport
 */
class DiffReport implements ReportInterface {

  public function getReport() {
    // TODO: Implement getReport() method.
  }

}

It would be best to remove this file, or mark it as ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants