Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support JavaScript and Twig deprecations #29

Closed
mglaman opened this issue Apr 10, 2019 · 2 comments
Closed

Support JavaScript and Twig deprecations #29

mglaman opened this issue Apr 10, 2019 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Issue triage

Comments

@mglaman
Copy link
Owner

mglaman commented Apr 10, 2019

Per Dries, we should add other deprecated code analysis. This is beyond PHPStan, so we'll need yo get creative.
@mglaman mglaman added enhancement New feature or request help wanted Extra attention is needed labels Apr 10, 2019
@mglaman mglaman added this to Needs triage in Issue triage May 3, 2019
@mglaman mglaman moved this from Needs triage to Needs Research in Issue triage May 3, 2019
@goba
Copy link
Sponsor

goba commented May 15, 2019

Cross-linking with https://www.drupal.org/project/upgrade_status/issues/3054924 where Lauri has an interesting idea of compiling the templates to get deprecation errors. That is not a static analyses step, but could work for the use case of Upgrade Status. (This is in the brainstorming phase).

@goba
Copy link
Sponsor

goba commented Jan 13, 2020

@lauriii solved the Twig portion inside a Drupal runtime at https://www.drupal.org/project/upgrade_status/issues/3054924 using existing Twig tooling in core. Is Drupal boostrapped enough in drupal-check / phpstan-drupal to integrate a similar solution?

@mglaman mglaman pinned this issue Jan 13, 2020
@mglaman mglaman closed this as completed Feb 4, 2022
Issue triage automation moved this from Needs Research to Closed Feb 4, 2022
@mglaman mglaman unpinned this issue Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Issue triage
  
Closed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@goba @mglaman