Fixes for issues discovered during MidCamp 2019

[josephdpurcell]

During MidCamp 2019 contribution day, a number of issues were surfaced that seem related to the checker. Those were documented here: https://docs.google.com/spreadsheets/d/1-W0k4vhdmw7ugzRdSa9orEc43_D5l6PPvUcrB8bw_-0/edit#gid=0

This ticket is to track resolution to those issues.

• Module redirect: PHP Warning: Uncaught PHPStan\Broker\ClassAutoloadingException: Class Symfony\Component\Validator\ExecutionContextInterface not found and could not be autoloaded.
• Module devel Class Drupal\Tests\devel_generate\DevelGenerateManagerTest was not found while trying to analyse it - autoloading is probably not configured properly.
• Module backup_migrate Class BackupMigrate\Core\Destination\NodeSquirrelDestination contains 1 abstract method and must therefore be declared abstract or implement the remaining methods
• Module libraries PHP Fatal error: Trait method getLibrary has not been applied, because there are collisions with other trait methods on Drupal\libraries\ExternalLibrary\Exception\InvalidLibraryDependencyException
• Module page_manager Fatal error: Declaration of Drupal\page_manager_ui\Wizard\RouteParameters::getOperations() must be compatible with Drupal\ctools\Wizard\FormWizardInterface::getOperations($cached_values)
• Module slick_views Fatal error: Cannot redeclare token_theme() (previously declared in web/modules/contrib/blazy/tests/modules/blazy_test/blazy_test.module:112) in web/modules/contrib/token/token.module on line 71
• Module draggableviews Warning: Uncaught PHPStan\Broker\ClassAutoloadingException: Class Drupal\migrate\Entity\MigrationInterface not found and could not be autoloaded
• Module video Fatal error: Cannot redeclare Drupal\video_transcode\TranscoderInterface::createJob()

Looking through the rest of the list I'm wondering if some of these are not issues with drupal-check but actually issues with the modules?

Perhaps the next step here then is to go through the "Problems with Drupal Checker" column of the spreadsheet and submit d.o tickets?

[mglaman]

Uncaught PHPStan\Broker\ClassAutoloadingException: Class Symfony\Component\Validator\ExecutionContextInterface not found and could not be autoloaded.

This sounds like a PHPStan Drupal bug.

Module devel Class Drupal\Tests\devel_generate\DevelGenerateManagerTest was not found while trying to analyse it - autoloading is probably not configured properly.

Test autoloading is broken, PHPStan Drupal bug

Module backup_migrate Class BackupMigrate\Core\Destination\NodeSquirrelDestination contains 1 abstract method and must therefore be declared abstract or implement the remaining methods

Legit PHP bug in backup_migrate

Module libraries PHP Fatal error: Trait method getLibrary has not been applied, because there are collisions with other trait methods on Drupal\libraries\ExternalLibrary\Exception\InvalidLibraryDependencyException

Legit PHP bug

Module page_manager Fatal error: Declaration of Drupal\page_manager_ui\Wizard\RouteParameters::getOperations() must be compatible with Drupal\ctools\Wizard\FormWizardInterface::getOperations($cached_values)

Legit PHP bug

Module slick_views Fatal error: Cannot redeclare token_theme() (previously declared in web/modules/contrib/blazy/tests/modules/blazy_test/blazy_test.module:112) in web/modules/contrib/token/token.module on line 71

Workaround fixed in phpstan-drupal, just need to do a round of releases

Module draggableviews Warning: Uncaught PHPStan\Broker\ClassAutoloadingException: Class Drupal\migrate\Entity\MigrationInterface not found and could not be autoloaded

PHPStan Drupal bug

Module video Fatal error: Cannot redeclare Drupal\video_transcode\TranscoderInterface::createJob()

Module bug

[mglaman]

Opened issue for Redirect: https://www.drupal.org/project/redirect/issues/3053016

[mglaman]

Opened issue for Devel: https://www.drupal.org/project/devel/issues/3053017

[mglaman]

All of these are bugs in the modules.