Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignoring all errors #190

Closed
MPParsley opened this issue Oct 13, 2020 · 1 comment · Fixed by #191
Closed

Fix ignoring all errors #190

MPParsley opened this issue Oct 13, 2020 · 1 comment · Fixed by #191

Comments

@MPParsley
Copy link
Contributor

How is drupal-check installed?

drupal-check is installed as a dependency to my project

Environment:

  • OS: macOS/Linux
  • PHP Version: 7.3
  • Drupal core: 8.9

Describe the bug
In #136 we accidentally ignored all errors instead of just the one error:
"Unsafe usage of new static()."

This results in drupal-check failing with the message below.

Console output

 -- -------------------------------------------------------------------------- 
     Error                                                                     
 -- -------------------------------------------------------------------------- 
     Ignored error #Unsafe usage of new static()# has an unescaped '()' which  
     leads to ignoring all errors. Use '\(\)' instead.                         
 -- -------------------------------------------------------------------------- 
@MPParsley MPParsley changed the title All errors are ignored Fix ignoring all errors Oct 13, 2020
@petk
Copy link

petk commented Oct 26, 2020

/o\

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants