installing with phar crashes because phpstan/phpstan not found

[joachim-n]

How is drupal-check installed?

• drupal-check is installed using the phar

Environment:

• OS: macOS
• PHP Version: 7.2
• Drupal core: 8.8

Describe the bug

I did drupal-check docroot/modules/custom/mymodule/

and got this:

sh: /Users/joachim/Sites/myproject/docroot/modules/custom/vendor/phpstan/phpstan/phpstan: No such file or directory
sh: line 0: exec: /Users/joachim/Sites/myproject/docroot/modules/custom/vendor/phpstan/phpstan/phpstan: cannot execute: No such file or directory

Console output
Paste the output of the console when running the command with -vvv

Current working directory: /Users/joachim/Sites/myproject
Using Drupal root: /Users/joachim/Sites/myproject/docroot
Using vendor root: /Users/joachim/Sites/myproject/vendor
PHPStan configuration:
parameters:
	tipsOfTheDay: false
	reportUnmatchedIgnoredErrors: false
	excludes_analyse:
		- */tests/Drupal/Tests/Listeners/Legacy/*
		- */tests/fixtures/*.php
		- */settings*.php

	drupal:
		drupal_root: /Users/joachim/Sites/myproject/docroot

	customRulesetUsed: true
	ignoreErrors:
		- "#\\Drupal calls should be avoided in classes, use dependency injection instead#"
		- "#Plugin definitions cannot be altered.#"
		- "#Missing cache backend declaration for performance.#"
		- "#Plugin manager has cache backend specified but does not declare cache tags.#"

	bootstrap: phar:https:///Users/joachim/bin/drupal-check/error-bootstrap.php

includes:
	- phar:https:///Users/joachim/bin/drupal-check/vendor/phpstan/phpstan-deprecation-rules/rules.neon
	- phar:https:///Users/joachim/bin/drupal-check/vendor/mglaman/phpstan-drupal/extension.neon


sh: /Users/joachim/Sites/myproject/vendor/phpstan/phpstan/phpstan: No such file or directory
sh: line 0: exec: /Users/joachim/Sites/myproject/vendor/phpstan/phpstan/phpstan: cannot execute: No such file or directory

[mglaman]

🤔

Okay, so I looked at the code again

        $pharPath = \Phar::running();
        if ($pharPath !== '') {
            // Running in packaged Phar archive.
            $phpstanBin = 'vendor/phpstan/phpstan/phpstan';

What I noticed is that the bin path doesn't use the $pharPath, like the following

            $configuration_data['parameters']['bootstrap'] = $pharPath . '/error-bootstrap.php';
            $configuration_data['includes'] = [
                $pharPath . '/vendor/phpstan/phpstan-deprecation-rules/rules.neon',
                $pharPath . '/vendor/mglaman/phpstan-drupal/extension.neon',
            ];

So that's why it used your current directory and appended vendor/phpstan/phpstan/phpstan.

/Users/joachim/Sites/myproject/vendor/phpstan/phpstan/phpstan

[mglaman]

Phar is just flat out broken. I'm closing this to track the complete problem in #167