Ignore “Unsafe usage of new static()” warning #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57ae733
to
4829d71
Compare
|
Tests are failing because of errors: |
|
Thanks, @kasperg ! I'm resolving the phpstan-drupal issue and then merging this |
This causes too many problems in Drupal were Drupal always uses new static instead of self. Initialize an empty array of errors to ignore and let different types of checks modify it. This way we support multiple check types where each add their own errors to ignore.
4829d71
to
9bd8b18
Compare
|
Rebased on |
bramtenhove
added a commit
to goalgorilla/open_social
that referenced
this pull request
Jan 20, 2021
…e usage of new static()' error in PHPStan See mglaman/drupal-check#187.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes too many problems in Drupal were Drupal always uses
new staticinstead ofnew self.Initialize an empty array of errors to ignore and let different types
of checks modify it. This way we support multiple check types where
each add their own errors to ignore.
This closes #136.