Lightning - Could not find autoload file

[amitgoyal]

We have setup Lightning locally as per the steps below,

git clone --branch 8.x-4.x https://git.drupalcode.org/project/lightning.git
composer install

We have also setup drupal-check at project level and trying to run it against couple of Lightning modules but getting "Could not find autoload file." error,

➜ lightning git:(8.x-4.x) ✗ ./vendor/bin/drupal-check -d docroot/modules/contrib/lightning_layout

Could not find autoload file.

We tried to debug this by printing $this->vendorRoot at line 108 in /lightning/vendor/mglaman/drupal-check/src/Command/CheckCommand.php and got

this->vendorRoot: /lightning/docroot/modules/contrib/lightning_layout/vendor

Not sure if it should look for "vendor" folder at root level or "lightning_layout/vendor".

We are able to run drupal-check against other modules successfully which are part of Lightning,
➜ lightning git:(8.x-4.x) ✗ ./vendor/bin/drupal-check -d docroot/modules/contrib/token

Any idea?

[grasmash]

I had this issue with lightning_core. It is because DrupalCheck incorrectly assumes that lightning_core is the docroot.

[amitgoyal]

BTW, we had temporarily hard coded "this->vendorRoot" in /lightning/vendor/mglaman/drupal-check/src/Command/CheckCommand.php to test the deprecations for Lightning modules.

That way we were able to progress for the time being.

[grasmash]

I see in the docs that there's a --drupal-root option for Drupal Check. Trying that now.

[grasmash]

Ah, it looks like that's not actually in a released version. I submitted a PR for achieving this with an environmental variable, which may no longer be necessary:
#103

[fgm]

This does not solve the issue (not even Lightning-specific): the code incorrectly assumes $this->vendorDir is in one level below $this->rootDir, although in composer-project or drupal-recommended layouts it is an "uncle" of the rootDir. It could find the vendor location using the Composer libraries instead of guessing, but doesn't do it.

[mglaman]

        $drupalFinder->locateRoot($drupalRootCandidate);
        $this->drupalRoot = $drupalFinder->getDrupalRoot();
        $this->vendorRoot = $drupalFinder->getVendorDir();

We directories are determined by the Drupal finder library. It doesn't make any assumptions beyond that. It just passes the Drupal root value to mglaman/phpstan-drupal.

[fgm]

Yes, the problem is in the drupalFinder resolution, as described above. The question is whether there is a way to initialize the finder to avoid the problem.