-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NaN discrepancy between older versions (<=1.5.11) and newer versions (>=1.6.0) #145
Comments
Thank you for reaching out @dcervenkov, I looked into this and I can confirm that you should use >= 1.6.0 for the correct data. Version 1.5.7 uses an outdated endpoint which is still available so we don't break existing installations. However, the data you're receiving from this endpoint was removed due to a bug in DWD MOSMIX data. |
Thanks for looking into this and explaining the situation, @clampr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I get different datasets from the same request in older and newer versions of meteostat. I narrowed it down to the jump from 1.5.11 to 1.6.0.
To make the comparison as apples-to-apples as possible, I'm using
pandas==2.0.3
which works with bothmeteostat==1.5.11
andmeteostat==1.6.0
.Steps to reproduce
meteostat 1.5.11
python3 -m venv venv_meteostat15 ./venv_meteostat15/bin/pip install pandas==2.0.3 meteostat==1.5.11 ./venv_meteostat15/bin/python -c "from meteostat import Hourly; import datetime; print(Hourly(loc='11520', start=datetime.datetime(2021, 1, 1, 0, 0, 0), end=datetime.datetime(2022, 11, 3, 23, 0, 0), timezone='Europe/Prague').normalize().fetch().info())"
Result
meteostat 1.6.0
python3 -m venv venv_meteostat16 ./venv_meteostat16/bin/pip install pandas==2.0.3 meteostat==1.6.0 ./venv_meteostat16/bin/python -c "from meteostat import Hourly; import datetime; print(Hourly(loc='11520', start=datetime.datetime(2021, 1, 1, 0, 0, 0), end=datetime.datetime(2022, 11, 3, 23, 0, 0), timezone='Europe/Prague').normalize().fetch().info())"
Result
Notice the
prcp
column has 12628 non-null values in 1.5.11 but only 3867 non-null values in 1.6.0!The text was updated successfully, but these errors were encountered: