[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign furkatgofurov7 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Hi @MeenuyD. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

/ok-to-test

Hi and thank you for the PR!
Could you fix all the points in the issue?
There was one for writing NIC in capital letters also here

Hi and thank you for the PR! Could you fix all the points in the issue? There was one for writing NIC in capital letters also here

cluster-api-provider-metal3/baremetal/metal3data_manager.go

Lines 1389 to 1396 in bec1704

	return "", errors.New("Nics list not populated")
	}
	for _, nics := range bmh.Status.HardwareDetails.NIC {
	if nics.Name == name {
	return nics.MAC, nil
	}
	}
	return "", fmt.Errorf("nic name not found %v", name)

I did not see your comments.

/lgtm cancel

Can you squash your commits, please?

/test-e2e-upgrade-main running to test the trigger

@MeenuyD Please squash the commits and fix the last comment (write NIC with capital letters). Then I think we can merge this 🙂

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

/remove-lifecycle stale
/lifecycle frozen

@Rozzii: The lifecycle/frozen label cannot be applied to Pull Requests.

/cc @adilGhaffarDev
Just to have 2 reviewer, btw we can take over this wdyt @adilGhaffarDev @Sunnatillo ? this was inactive for 90 days

/cc @adilGhaffarDev Just to have 2 reviewer, btw we can take over this wdyt @adilGhaffarDev @Sunnatillo ? this was inactive for 90 days

Agree. We should take over