fix: handled errors on /upload endpoint #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Creatoon what about already written files like metacall_json to the disk , You need to delete after error. I was doing first like this but later falled back to try catch to handle sending all the possible errors . |
|
@durgesh077 we are not writing any json file to the disk at the time of package creation, it happens in the deploying phase. Also, anything will only be written to the disk once callback fired by busboy runs successfully. If there will be any error all the data will be flushed out as it's in the memory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #16
Closed the pipe from req to bus boy as If any error occurs, we will stop feeding the data.
I offloaded the work of each event (field, file) to work queue, such that if any error occurs then we can pause the processing queue and and finally prevent the bus boy events from firing callbacks on the data that has already been piped.