-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Milestone Reminder GH Action doesn't always work #42835
Comments
I'm probably missing something, but if a PR doesn't have a closing keyword, that means it's not connected to an issue, which in turn means the PR itself should have a milestone, so I'm lost about the #2 in the description. |
Not always. There are a ton of tech debt PRs that don't really need a milestone. I'm not aware that we're enforcing a milestone in 100% of cases? |
not 100% but (1) better too many PRs than too few, (2) many tech debt PRs should have a milestons, (3) the reminder doesn't know a difference. let's continue this discussion on the notion doc explaining our usage of milestones |
Describe the bug
We have a very useful milestone reminder GH action, but it doesn't always work as expected.
There are two scenarios we need to fix:
To Reproduce
Closes #12345 and #23456
or
Expected behavior
Logs
No response
Information about your Metabase installation
.
Severity
p3
Additional context
Internal.
The text was updated successfully, but these errors were encountered: