Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor request: streamline dependencies #392

Closed
cachho opened this issue Aug 2, 2023 · 0 comments · Fixed by #416
Closed

refactor request: streamline dependencies #392

cachho opened this issue Aug 2, 2023 · 0 comments · Fixed by #416
Labels
help wanted Extra attention is needed

Comments

@cachho
Copy link
Contributor

cachho commented Aug 2, 2023

🐛 Describe the bug

I have reported this in #335, on discord, and now it popped up again in #391.

  • dependencies are different in setup.py and pyproject.toml
  • should make all embedding and LLM models a requirement, when a user only has to use one app type? - or should it only be some, or none? Users could then install what they want to use.
  • when we make changes: how does it affect dev, CI/CD and tests?
@cachho cachho added the help wanted Extra attention is needed label Aug 2, 2023
This was referenced Aug 4, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: dependencies cachho/embedchain
1 participant
@cachho