Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joining audiobridge is locked to opus codec only #41

Closed
pawnnail opened this issue May 10, 2024 · 0 comments
Closed

Joining audiobridge is locked to opus codec only #41

pawnnail opened this issue May 10, 2024 · 0 comments

Comments

@pawnnail
Copy link

Have come across a problem where joining as a plain rtp with a codec other that opus is impossible. Being irrelevant whether a participant is plain rtp or not, it seems join() is missing the 'codec' param. In my case, I was trying to join as a plain rtp participant with pcmu or pcma.

The fix is trivial, just adding the codec param to the join method (and documentation) does the trick. Something like that:

async join({ room, ..., generate_offer, codec }) {
  const body = {
      request: REQUEST_JOIN,
      room,
    };
...
...
    if (typeof codec === 'string') body.codec = codec;
    if (typeof muted === 'boolean') body.muted = muted;
...
}

I hope I am not missing anything.

@atoppi atoppi closed this as completed in b1439ad Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant