Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic WebSocket observability #4685

Open
ThatOneBro opened this issue Jun 18, 2024 · 1 comment
Open

Add basic WebSocket observability #4685

ThatOneBro opened this issue Jun 18, 2024 · 1 comment
Labels
subscriptions Features and fixes related to subscriptions
Milestone
Milestone Quality

Comments

@ThatOneBro
Copy link
Member

ThatOneBro commented Jun 18, 2024 •
edited
Loading

We should add some simple metrics for things like number of concurrent WebSocket connections, etc.

Probably should add simple OTel instrumentation for the ws package, maybe we should look here for inspiration:
https://github.com/gadget-inc/opentelemetry-instrumentations
@ThatOneBro ThatOneBro added the subscriptions Features and fixes related to subscriptions label Jun 18, 2024
@ThatOneBro ThatOneBro added this to the Milestone Quality milestone Jun 18, 2024
@dillonstreator dillonstreator mentioned this issue Jun 21, 2024
Closed
@ThatOneBro
Copy link
Member Author

Partially fulfilled by #4782

Probably still want things like average bandwidth per WS (in bytes), maybe average messages sent per WS / sec, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
subscriptions Features and fixes related to subscriptions
Projects
Medplum Product Roadmap
Status: No status
Milestone
Milestone Quality
Development

No branches or pull requests
1 participant
@ThatOneBro