Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validateCriteria util #4539

Closed
ThatOneBro opened this issue May 10, 2024 · 1 comment
Closed

Add validateCriteria util #4539

ThatOneBro opened this issue May 10, 2024 · 1 comment
Assignees
Labels
auth Authentication and authorization features and fixes

Comments

@ThatOneBro
Copy link
Member

This would be helpful for validating criteria in several places, including preventing invalid criteria from being entered during AccessPolicy creation. The initial implementation can be simple and just validate the format; later on we can also check for valid search parameters and values (eg. validate that references in the criteria exist)

@ThatOneBro ThatOneBro added this to the Milestone Quality milestone May 10, 2024
@rahul1 rahul1 added the auth Authentication and authorization features and fixes label Sep 4, 2024
@mattwiller
Copy link
Member

This is mostly resolved by #5170 — that checks for the correct format (a search string with query parameters)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth Authentication and authorization features and fixes
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants