Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent false positives from isSeeded() #4438

Open
ThatOneBro opened this issue Apr 23, 2024 · 0 comments
Open

Prevent false positives from isSeeded() #4438

ThatOneBro opened this issue Apr 23, 2024 · 0 comments

Comments

@ThatOneBro
Copy link
Member

ThatOneBro commented Apr 23, 2024

Currently the implementation is this:

function isSeeded(): Promise<User | undefined> {
  const systemRepo = getSystemRepo();
  return systemRepo.searchOne({ resourceType: 'User' });
}

This works most of the time but doesn't detect broken states automatically and can lead to weird behavior in tests, especially if Redis is caching resources from a previous environment but the database is fresh.

@ThatOneBro ThatOneBro added this to the Milestone Quality milestone Apr 23, 2024
@ThatOneBro ThatOneBro changed the title Prevent false positives in isSeeded() Prevent false positives from isSeeded() Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant