Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make code parameter from Bot/$deploy optional #4353

Open
rahul1 opened this issue Apr 10, 2024 · 2 comments
Open

Make code parameter from Bot/$deploy optional #4353

rahul1 opened this issue Apr 10, 2024 · 2 comments
Labels
bots Features and fixes related to bots and automation

Comments

@rahul1
Copy link
Member

rahul1 commented Apr 10, 2024

Long ago, the Bot resource only stored the source code, and the compiled code was set during $deploy

Now we store both the source and compiled code as Attachments on the Bot resource, so the code parameter on the $deploy operation is unncessary. We can make it optional and then deprecate in v4

@rahul1 rahul1 added this to the Milestone Quality milestone Apr 10, 2024
@reshmakh reshmakh added the bots Features and fixes related to bots and automation label Apr 13, 2024
@codyebberson
Copy link
Member

Make optional: yes

Deprecate: any reason? just to simplify the API?

@rahul1
Copy link
Member Author

rahul1 commented Apr 19, 2024

Just to simplify the API. Or alternatively, have $deploy also accept the source code. Right now it's weird that it only accepts one of the two types of "code" linked to a Bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bots Features and fixes related to bots and automation
Projects
Status: No status
Development

No branches or pull requests

3 participants