Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription Signature Verification on Deleted Resource #4198

Open
tristin-terry opened this issue Mar 19, 2024 · 0 comments
Open

Subscription Signature Verification on Deleted Resource #4198

tristin-terry opened this issue Mar 19, 2024 · 0 comments

Comments

@tristin-terry
Copy link

Hello, I am trying to use a REST subscription with signature verification based on the docs provided here: https://www.medplum.com/docs/subscriptions/subscription-extensions#signatures

I noticed that the signature doesn't match for Delete events.

It looks like the signature is generated using the resource that was deleted instead of the body that is sent ({}) based on https://github.com/medplum/medplum/blob/main/packages/server/src/workers/subscription.ts#L571

Is this intentional?

I would expect any of the following would allow the signatures to match on deleted resources:

  • a signature based on the {} body
  • include the deleted resource in the body instead of {}
  • use the content of the X-Medplum-Deleted-Resource header instead of the body for deleted resource signatures

ref: discord support thread

@codyebberson codyebberson added this to the Milestone Quality milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants