Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useSubscription should unsubscribe from the previous criteria when switching criteria / subscriptionProps #4197

Open
ThatOneBro opened this issue Mar 19, 2024 · 0 comments
Open

useSubscription should unsubscribe from the previous criteria when switching criteria / subscriptionProps #4197

ThatOneBro opened this issue Mar 19, 2024 · 0 comments
Milestone
Milestone Quality

Comments

@ThatOneBro
Copy link
Member

ThatOneBro commented Mar 19, 2024 •
edited
Loading

Currently when criteria is changed for useSubscription, the previous criteria is not unsubscribed from because the timer on rerun of the effect is reset by the next criteria being subscribed to...

We should probably track each criteria separately with separate timers keyed off of criteria and subscriptionProps
@ThatOneBro ThatOneBro changed the title SubscriptionManager should unsubscribe from the previous criteria when switching criteria / subscriptionProps useSubscription should unsubscribe from the previous criteria when switching criteria / subscriptionProps Mar 19, 2024
@ThatOneBro ThatOneBro added this to the Milestone Quality milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Medplum Product Roadmap
Status: No status
Milestone
Milestone Quality
Development

No branches or pull requests
1 participant
@ThatOneBro