Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(server): add test.config.json with port 8104 #3329

Merged
merged 1 commit into from
Nov 16, 2023
Merged

test(server): add test.config.json with port 8104 #3329

merged 1 commit into from
Nov 16, 2023

Conversation

ThatOneBro
Copy link
Member

Fixes #3326

@ThatOneBro ThatOneBro requested a review from a team as a code owner November 16, 2023 05:00
@vercel Vercel
Copy link

vercel bot commented Nov 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
medplum-storybook ⬜️ Ignored (Inspect) Nov 16, 2023 5:00am
medplum-www ⬜️ Ignored (Inspect) Nov 16, 2023 5:00am

@sweep-ai Sweep AI
Copy link
Contributor

sweep-ai bot commented Nov 16, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@github-actions GitHub Actions
Copy link

Messages
📖 @medplum/core: 141.4 kB
📖 @medplum/react: 191.2 kB

Generated by 🚫 dangerJS against 3c01a06

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 16, 2023 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 16, 2023
View reviewed changes
packages/server/test.config.json Dismissed Show dismissed Hide dismissed
mattwiller
mattwiller approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@mattwiller mattwiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome QOL fix, this bites me all the time

@ThatOneBro ThatOneBro added this pull request to the merge queue Nov 16, 2023
Merged via the queue into main with commit ee0a340 Nov 16, 2023
14 checks passed
@ThatOneBro ThatOneBro deleted the derrick-separate-port-for-tests branch November 16, 2023 20:30
codyebberson added a commit that referenced this pull request Nov 19, 2023
@codyebberson
Release Version 2.1.15
e7feccb 
Refinements and additions fot Health Gorilla documentation as we proceed through testing (#3333)
Tighter input validation on security endpoints (#3334)
Use react-jsx transform (#3338)
Create documentation for chained search (#3312)
Document performing insurance eligibility checks (#3280)
feat(expo): add `ExpoClientStorage` for persisted store in RN (#3307)
test(server): add `test.config.json` with port `8104` (#3329)
Make Postgres version configurable in CDK (#3327)
Configure agent service name and automatic start (#3321)
Link authentication methods to relevant Medplum Client functions (#3323)
server centralize request validation for co-location and reduced redundancy (#3228)
Fixed FHIR link (#3319)
@codyebberson codyebberson mentioned this pull request Nov 19, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 19, 2023
@codyebberson
Release Version 2.1.15 (#3339)
ab33abf 
Refinements and additions fot Health Gorilla documentation as we proceed through testing (#3333)
Tighter input validation on security endpoints (#3334)
Use react-jsx transform (#3338)
Create documentation for chained search (#3312)
Document performing insurance eligibility checks (#3280)
feat(expo): add `ExpoClientStorage` for persisted store in RN (#3307)
test(server): add `test.config.json` with port `8104` (#3329)
Make Postgres version configurable in CDK (#3327)
Configure agent service name and automatic start (#3321)
Link authentication methods to relevant Medplum Client functions (#3323)
server centralize request validation for co-location and reduced redundancy (#3228)
Fixed FHIR link (#3319)
@reshmakh reshmakh added this to the November 30, 2023 milestone Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattwiller mattwiller mattwiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Medplum Product Roadmap
Archived in project
Milestone
November 30, 2023
Development

Successfully merging this pull request may close these issues.

Use a separate default port for running @medplum/server tests
3 participants
@ThatOneBro @mattwiller @reshmakh