feat(expo): add `ExpoClientStorage` for persisted store in RN #3307

ThatOneBro · 2023-11-11T05:02:14Z

Needs some cleanup but mostly done. Working well on Android device. Still need to add a few tests too.

TODO:

Add tests
Change error to OperationOutcomeError
Clean up .catchs
Fix repeated call to removeKey invoking several calls to setKeys in clear
Test MedplumProvider setting and unsetting loading
Add docs for how to await initialized and what it means
Add docs for how to use the loading state from useMedplumContext

vercel · 2023-11-11T05:02:21Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
medplum-storybook	⬜️ Ignored (Inspect)	Visit Preview		Nov 17, 2023 1:09am
medplum-www	⬜️ Ignored (Inspect)	Visit Preview		Nov 17, 2023 1:09am

sweep-ai · 2023-11-11T05:03:18Z

Apply Sweep Rules to your PR?

Apply: All new business logic should have corresponding unit tests.
Apply: Refactor large functions to be more modular.

github-actions · 2023-11-11T05:06:15Z

✅ prettier errors have been resolved. Thank you.

^{#cd5357dd2c700cb62837819e74f5054b675db19f}

github-actions · 2023-11-13T23:39:11Z

	Messages
📖	@medplum/core: 141.9 kB
📖	@medplum/react: 191.4 kB

Generated by 🚫 dangerJS against 8c5ef7d

packages/expo-polyfills/package.json

codyebberson

Clever solution to a hard problem. Looks good from structural perspective. A bunch of nitpicky style comments.

packages/core/src/client.ts

packages/expo-polyfills/src/index.test.ts

codyebberson · 2023-11-14T21:43:19Z

packages/expo-polyfills/src/index.ts

+class SyncSecureStorage implements Storage {
+ private readonly storage: Map<string, string>;
+ private readonly initPromise: Promise<void>;
+ private isInitialized = false;


Probably pedantic, but I think the recommended model for boolean naming is:

noun for the variable name (i.e., initialized)

is prefix for a getter (i.e., isInitialized())

True,

In this case was trying to avoid collision with initialized Promise on the object... but yeah you're 100% right

packages/react-hooks/src/MedplumProvider/MedplumProvider.tsx

examples/medplum-react-native-example/src/Home.tsx

codyebberson · 2023-11-14T21:47:34Z

packages/expo-polyfills/package.json

@@ -42,6 +43,7 @@
 "esbuild": "0.19.5",
 "esbuild-node-externals": "1.9.0",
 "jest": "29.7.0",
+ "jest-expo": "^49.0.0",


Why jest-expo? I don't see any calls to it. And it's big :(

It's the test environment for Expo, it actually fixes a lot of problems with react-native preset, and better represents the various environments for Android, iOS, and Web as separate environments. See the jest.config.json:

medplum/packages/expo-polyfills/jest.config.json

Line 2 in 2c3fe80

"projects": [{ "preset": "jest-expo/ios" }, { "preset": "jest-expo/android" }],

packages/core/src/client.ts

ThatOneBro · 2023-11-15T23:49:45Z

After the introduction of the ExpoClientStorage, this should be the minimal example of using MedplumClient in React Native.

If you want to wait to load components until after the MedplumClient has initialized, you can conditionally render based on the loading property from the useMedplumContext hook, like so:

import { MedplumClient } from '@medplum/core';
import { MedplumProvider, useMedplumContext } from '@medplum/react-hooks';
import { polyfillMedplumWebAPIs, ExpoClientStorage } from '@medplum/expo-polyfills';

polyfillMedplumWebAPIs();

const medplum = new MedplumClient({ storage: new ExpoClientStorage() });

function Home(): JSX.Element {
  const { loading } = useMedplumContext();
  return loading ? <div>Loading...</div> : <div>Loaded!</div>;
}

function App(): JSX.Element {
  return (
    <MedplumProvider medplum={medplum}>
      <Home />
    </MedplumProvider>
  );
}

Any thoughts @codyebberson @rhys-jmc ?

sonarcloud · 2023-11-17T01:23:57Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

94.0% Coverage
0.0% Duplication

ThatOneBro · 2023-11-17T01:31:06Z

packages/expo-polyfills/src/index.ts

+ private secureStorage?: SyncSecureStorage;
+ constructor() {
+ // Metro should automatically prune these branches out at compile time
+ if (Platform.OS === 'web') {


Does this seem like a sane way to handle the React Native Web case? These checks should compile out when Metro compiles the final app. @codyebberson

Seems reasonable - it's exported by Expo, so feels official.

codyebberson

Nice, thanks @ThatOneBro

Refinements and additions fot Health Gorilla documentation as we proceed through testing (#3333) Tighter input validation on security endpoints (#3334) Use react-jsx transform (#3338) Create documentation for chained search (#3312) Document performing insurance eligibility checks (#3280) feat(expo): add `ExpoClientStorage` for persisted store in RN (#3307) test(server): add `test.config.json` with port `8104` (#3329) Make Postgres version configurable in CDK (#3327) Configure agent service name and automatic start (#3321) Link authentication methods to relevant Medplum Client functions (#3323) server centralize request validation for co-location and reduced redundancy (#3228) Fixed FHIR link (#3319)

vercel bot had a problem deploying to Preview – medplum-storybook November 11, 2023 05:05 Failure

ThatOneBro force-pushed the derrick-fix-react-native-login-persistence branch from 6896b64 to b9a1829 Compare November 11, 2023 05:06

ThatOneBro changed the title ~~feat(expo): add ExpoClientStorage for persisted store on RN~~ feat(expo): add ExpoClientStorage for persisted store in RN Nov 11, 2023

vercel bot deployed to Preview – medplum-storybook November 11, 2023 05:13 View deployment

ThatOneBro force-pushed the derrick-fix-react-native-login-persistence branch 2 times, most recently from 2615998 to d81ad52 Compare November 13, 2023 23:01

ThatOneBro marked this pull request as ready for review November 13, 2023 23:24

ThatOneBro requested a review from a team as a code owner November 13, 2023 23:24

reshmakh added the integration label Nov 13, 2023

vercel bot deployed to Preview – medplum-storybook November 13, 2023 23:59 View deployment

vercel bot deployed to Preview – medplum-www November 14, 2023 00:05 View deployment

rhys-jmc reviewed Nov 14, 2023

View reviewed changes

packages/expo-polyfills/package.json Outdated Show resolved Hide resolved

codyebberson reviewed Nov 14, 2023

View reviewed changes

vercel bot deployed to Preview – medplum-www November 15, 2023 22:46 View deployment

vercel bot deployed to Preview – medplum-storybook November 15, 2023 22:50 View deployment

vercel bot deployed to Preview – medplum-www November 15, 2023 23:21 View deployment

vercel bot deployed to Preview – medplum-storybook November 15, 2023 23:25 View deployment

vercel bot deployed to Preview – medplum-www November 16, 2023 06:29 View deployment

vercel bot deployed to Preview – medplum-storybook November 16, 2023 06:33 View deployment

ThatOneBro self-assigned this Nov 16, 2023

ThatOneBro added 5 commits November 16, 2023 14:47

feat(expo): add ExpoClientStorage for persisted store in RN

fed116e

chore(prettier): fix formatting

2f7051c

perf(expo): only call this.setKeys once on .clear

0fc6326

test(expo): add some tests for ExpoClientStorage, cleanup

280f45e

cleanup: fix comment

787d34f

ThatOneBro added 12 commits November 16, 2023 14:47

chore(expo): move expo deps to peerDeps

cebf764

test(react-hooks): add test for loading in MedplumProvider

f0584fd

refactor(client): add optional mem fn to ClientStorage

9e602fa

refactor: isInitialized field -> initialized

9b2e295

cleanup: remove unused test

1b5a975

cleanup: .catch(console.error)

b90c994

cleanup: remove unnecessary .catch

1a3b8f6

fix(client): initPromise should be attemptLoginPromise

f914fff

docs(expo-polyfills): add usage example

8a650ed

cleanup: remove stray ip

a46ac9d

cleanup: wording in README

4fa5c74

refactor(mock): move MockAsyncClientStorage to @medplum/mock

8f628dd

codyebberson approved these changes Nov 16, 2023

View reviewed changes

fix(expo): make ExpoClientStorage work on RN Web

6aacaed

ThatOneBro force-pushed the derrick-fix-react-native-login-persistence branch from 12cfbb5 to 6aacaed Compare November 17, 2023 00:57

ThatOneBro added 2 commits November 16, 2023 16:58

cleanup: remove stray ip

8f3a028

chore(expo): clarify comment about ExpoClientStorage

8c5ef7d

ThatOneBro added this pull request to the merge queue Nov 17, 2023

ThatOneBro removed this pull request from the merge queue due to a manual request Nov 17, 2023

ThatOneBro commented Nov 17, 2023

View reviewed changes

reshmakh added this to the November 30, 2023 milestone Nov 17, 2023

codyebberson approved these changes Nov 17, 2023

View reviewed changes

ThatOneBro added this pull request to the merge queue Nov 17, 2023

Merged via the queue into main with commit 077654f Nov 17, 2023
14 checks passed

ThatOneBro deleted the derrick-fix-react-native-login-persistence branch November 17, 2023 17:00

codyebberson mentioned this pull request Nov 19, 2023

Release Version 2.1.15 #3339

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(expo): add `ExpoClientStorage` for persisted store in RN #3307

feat(expo): add `ExpoClientStorage` for persisted store in RN #3307

ThatOneBro commented Nov 11, 2023 •

edited

Loading

vercel bot commented Nov 11, 2023 •

edited

Loading

sweep-ai bot commented Nov 11, 2023

github-actions bot commented Nov 11, 2023 •

edited

Loading

github-actions bot commented Nov 13, 2023 •

edited

Loading

codyebberson left a comment

codyebberson Nov 14, 2023

ThatOneBro Nov 14, 2023

codyebberson Nov 14, 2023

ThatOneBro Nov 14, 2023 •

edited

Loading

ThatOneBro commented Nov 15, 2023

sonarcloud bot commented Nov 17, 2023

ThatOneBro Nov 17, 2023 •

edited

Loading

codyebberson Nov 17, 2023

codyebberson left a comment

feat(expo): add ExpoClientStorage for persisted store in RN #3307

feat(expo): add ExpoClientStorage for persisted store in RN #3307

Conversation

ThatOneBro commented Nov 11, 2023 • edited Loading

TODO:

vercel bot commented Nov 11, 2023 • edited Loading

sweep-ai bot commented Nov 11, 2023

Apply Sweep Rules to your PR?

github-actions bot commented Nov 11, 2023 • edited Loading

github-actions bot commented Nov 13, 2023 • edited Loading

codyebberson left a comment

Choose a reason for hiding this comment

codyebberson Nov 14, 2023

Choose a reason for hiding this comment

ThatOneBro Nov 14, 2023

Choose a reason for hiding this comment

codyebberson Nov 14, 2023

Choose a reason for hiding this comment

ThatOneBro Nov 14, 2023 • edited Loading

Choose a reason for hiding this comment

ThatOneBro commented Nov 15, 2023

sonarcloud bot commented Nov 17, 2023

ThatOneBro Nov 17, 2023 • edited Loading

Choose a reason for hiding this comment

codyebberson Nov 17, 2023

Choose a reason for hiding this comment

codyebberson left a comment

Choose a reason for hiding this comment

feat(expo): add `ExpoClientStorage` for persisted store in RN #3307

feat(expo): add `ExpoClientStorage` for persisted store in RN #3307

ThatOneBro commented Nov 11, 2023 •

edited

Loading

vercel bot commented Nov 11, 2023 •

edited

Loading

github-actions bot commented Nov 11, 2023 •

edited

Loading

github-actions bot commented Nov 13, 2023 •

edited

Loading

ThatOneBro Nov 14, 2023 •

edited

Loading

ThatOneBro Nov 17, 2023 •

edited

Loading