Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth/external): make PKCE on external auth optional #3279

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

ThatOneBro
Copy link
Member

What this PR does

@ThatOneBro ThatOneBro requested a review from a team as a code owner November 9, 2023 07:28
Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medplum-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 7:38am
medplum-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 7:38am

Copy link
Contributor

sweep-ai bot commented Nov 9, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

Copy link

github-actions bot commented Nov 9, 2023

Messages
📖 @medplum/core: 141.4 kB
📖 @medplum/react: 188.6 kB

Generated by 🚫 dangerJS against 1164b7c

Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@codyebberson codyebberson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@ThatOneBro ThatOneBro added this pull request to the merge queue Nov 9, 2023
Merged via the queue into main with commit ed445f3 Nov 9, 2023
14 checks passed
@ThatOneBro ThatOneBro deleted the derrick-add-optional-pkce-external-auth branch November 9, 2023 17:59
codyebberson added a commit that referenced this pull request Nov 9, 2023
chore(actions): add console output for `prettier-fmt` Actions workflow (#3278)
feat(auth/external): make `PKCE` on external auth optional (#3279)
server/fhir/repo execute independent io concurrently (#3227)
MeasureReportDisplay   (#3242)
Create documentation on creating test data using batches (#3247)
Clarify project admin vs. Super admin (#3267)
feat(fhircast): add `FHIRcast` OAuth 2.0 scopes (#3274)
Adding Health Gorilla setup documentation and samples (#3250)
fix-3238 gracefully shutdown server (#3239)
github-merge-queue bot pushed a commit that referenced this pull request Nov 9, 2023
* Release Version 2.1.12

chore(actions): add console output for `prettier-fmt` Actions workflow (#3278)
feat(auth/external): make `PKCE` on external auth optional (#3279)
server/fhir/repo execute independent io concurrently (#3227)
MeasureReportDisplay   (#3242)
Create documentation on creating test data using batches (#3247)
Clarify project admin vs. Super admin (#3267)
feat(fhircast): add `FHIRcast` OAuth 2.0 scopes (#3274)
Adding Health Gorilla setup documentation and samples (#3250)
fix-3238 gracefully shutdown server (#3239)

* Fix package-lock.json
@reshmakh reshmakh added this to the November 30, 2023 milestone Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to disable PKCE on signInWithExternalAuth
3 participants