-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fhircast): add context.priorVersionId
to DiagnosticReport-update
#3232
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Apply Sweep Rules to your PR?
|
dc4738e
to
44c257a
Compare
Kudos, SonarCloud Quality Gate passed! |
event['context.versionId'] = generateId(); | ||
stringifiedBody = JSON.stringify(req.body); | ||
// TODO: Make sure this is actually supposed to be stored / overwrite open context? (ambiguous from docs, see: https://build.fhir.org/ig/HL7/fhircast-docs/2-9-GetCurrentContext.html) | ||
await getRedis().set(`::fhircast::${req.params.topic}::latest::`, stringifiedBody); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, why double colons? And why the double colon prefix?
In the rest of the server, we use single slash /
, mostly because I didn't know any better when we started.
If I were to do it from scratch, I'd use single colon :
, because a lot of Redis tools use that as a standard delimiter, which can help with visualization and debugging.
As far as I know, there is no actual behavior differences, Redis treats them all as opaque strings. So just curious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the idea was to kind of make it clear this is an internal key when looking through Redis, but maybe that's unnecessary. If it doesn't sit well I can change it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
One minor comment on Redis keys. Feel free to disregard.
fix(react-native-example): get login working on mobile (#2780) Document "Security Best Practices" for Auth (#3249) Updated Health Gorilla demo to use organization references (#3264) Convert @medplum/react into a module (#3259) Make request logging optional (#3261) Update Health Gorilla demo bot to support multiple Coverages (#3262) Document modeling why a communication was started with reasonCode (#3236) Added example test of patients already being merged (#3260) Added Health Gorilla ABN check (#3257) Added redirects for common search landing pages (#3256) Fix broken links identified by Ahrefs (#3255) Fix `:missing` modifier for token search params (#3218) Add VSCode setting to disable eslint fixAll on save (#3248) fix(fhircast): lower -> mixed, eg. `patient-open` -> `Patient-open` (#3237) Update generator step to run baseschema generator (#3245) Move Coveralls to separate Github Action (#3246) feat(fhircast): add `context.priorVersionId` to `DiagnosticReport-update` (#3232) HMR app on react changes (#3229) Log more details on external auth failure (#3244) Fixes #2703 - document agent system requirements (#3241) Make PKCE optional for external auth providers (#3243) Fixes #2892 - Use Mantine components for field editor (#3234) Added AOE QuestionnaireResponse to Health Gorilla example (#3230) Fixed prettier errors (#3231) Fixes #3215 - external auth fixes for Azure SSO (#3226) Middleware to log necessary data for every request. (#3196) Replace typedoc with api-documenter (#3172) feat(client/fhircast): add `DiagnosticReport-{update,select}` events (#3212) Typo (#3223) Fixes 2890 (#3220) Support custom creation paths (#3214) Suppress warnings from system repo (#3208) Fix "Id" capitolization issue in field selector (#3210) Adjust limit for chained searches (#3206) Fixes #3203 - check references on write with access policy (#3207) Add documentation on resource history (#3182) Fixed api-extractor warnings (#3205) Add placeholder value for identifier references (#3201) Implement search chaining (#3166) Updated Health Gorilla example with Account, Coverage, RelatedPerson (#3202) feat(server/fhircast): add versioning of `DiagnosticReport-open` (#3193) Show display for empty answer selection (#3192) feat(fhircast): add support for `GetCurrentContext` (#3181) Update Next Example project to use App Router (#3197) feat: Pass resource to Repository logEvent on error (#3195) Add documentation for FHIR batch requests (#3175) Fix NPE in reference validation logic (#3186) Add example of how to use optional --base-url flag (#3187) Add to folder structure (#3180) Unique Names for Add Group Button (#3191) Fixed warnings in publish action (#3165) Clarify the Medplum Project Model (#3179) Move to separate file (#3178) Add support for reference type (#3167) Markdown fixes for Docusaurus 3 (#3171) Updating integrations page with refreshed content (#3173) Index medplum-resource search params in example bots (#3164) Add params to MultiSelect for display in modal (#3174) test(client/fhircast): multiple of same key on `diagnosticreport-open` (#3168) Blog Post: Digital Health Operations (#3156) Fixed add-to-project version string (#3162) Add sort-package-json tool (#3161) Adding links from "User Admin Guide" to the '/invite' API (#3158) docs(config): add docs for `external secrets` (#3157) Adding links from "User Admin Guide" to the '/invite' API Refactor QuestionnaireForm (#3109) feat(client/fhircast): add support for `STU3` events (#3143) Health Gorilla diagnosis codes, specimen datetiem, and order notes (#3155) Require hyphen after @param jsdoc (#3154)
fix(react-native-example): get login working on mobile (#2780) Document "Security Best Practices" for Auth (#3249) Updated Health Gorilla demo to use organization references (#3264) Convert @medplum/react into a module (#3259) Make request logging optional (#3261) Update Health Gorilla demo bot to support multiple Coverages (#3262) Document modeling why a communication was started with reasonCode (#3236) Added example test of patients already being merged (#3260) Added Health Gorilla ABN check (#3257) Added redirects for common search landing pages (#3256) Fix broken links identified by Ahrefs (#3255) Fix `:missing` modifier for token search params (#3218) Add VSCode setting to disable eslint fixAll on save (#3248) fix(fhircast): lower -> mixed, eg. `patient-open` -> `Patient-open` (#3237) Update generator step to run baseschema generator (#3245) Move Coveralls to separate Github Action (#3246) feat(fhircast): add `context.priorVersionId` to `DiagnosticReport-update` (#3232) HMR app on react changes (#3229) Log more details on external auth failure (#3244) Fixes #2703 - document agent system requirements (#3241) Make PKCE optional for external auth providers (#3243) Fixes #2892 - Use Mantine components for field editor (#3234) Added AOE QuestionnaireResponse to Health Gorilla example (#3230) Fixed prettier errors (#3231) Fixes #3215 - external auth fixes for Azure SSO (#3226) Middleware to log necessary data for every request. (#3196) Replace typedoc with api-documenter (#3172) feat(client/fhircast): add `DiagnosticReport-{update,select}` events (#3212) Typo (#3223) Fixes 2890 (#3220) Support custom creation paths (#3214) Suppress warnings from system repo (#3208) Fix "Id" capitolization issue in field selector (#3210) Adjust limit for chained searches (#3206) Fixes #3203 - check references on write with access policy (#3207) Add documentation on resource history (#3182) Fixed api-extractor warnings (#3205) Add placeholder value for identifier references (#3201) Implement search chaining (#3166) Updated Health Gorilla example with Account, Coverage, RelatedPerson (#3202) feat(server/fhircast): add versioning of `DiagnosticReport-open` (#3193) Show display for empty answer selection (#3192) feat(fhircast): add support for `GetCurrentContext` (#3181) Update Next Example project to use App Router (#3197) feat: Pass resource to Repository logEvent on error (#3195) Add documentation for FHIR batch requests (#3175) Fix NPE in reference validation logic (#3186) Add example of how to use optional --base-url flag (#3187) Add to folder structure (#3180) Unique Names for Add Group Button (#3191) Fixed warnings in publish action (#3165) Clarify the Medplum Project Model (#3179) Move to separate file (#3178) Add support for reference type (#3167) Markdown fixes for Docusaurus 3 (#3171) Updating integrations page with refreshed content (#3173) Index medplum-resource search params in example bots (#3164) Add params to MultiSelect for display in modal (#3174) test(client/fhircast): multiple of same key on `diagnosticreport-open` (#3168) Blog Post: Digital Health Operations (#3156) Fixed add-to-project version string (#3162) Add sort-package-json tool (#3161) Adding links from "User Admin Guide" to the '/invite' API (#3158) docs(config): add docs for `external secrets` (#3157) Adding links from "User Admin Guide" to the '/invite' API Refactor QuestionnaireForm (#3109) feat(client/fhircast): add support for `STU3` events (#3143) Health Gorilla diagnosis codes, specimen datetiem, and order notes (#3155) Require hyphen after @param jsdoc (#3154)
Closes #3213