Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client/auth): respect accessToken in constructor #3066

Merged
merged 3 commits into from
Oct 18, 2023
Merged

fix(client/auth): respect accessToken in constructor #3066

merged 3 commits into from
Oct 18, 2023

Conversation

ThatOneBro
Copy link
Member

Fixes #3065

@ThatOneBro ThatOneBro requested a review from a team as a code owner October 17, 2023 22:53
@vercel
Copy link

vercel bot commented Oct 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medplum-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 0:28am
medplum-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 0:28am

@sweep-ai
Copy link
Contributor

sweep-ai bot commented Oct 17, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@ThatOneBro ThatOneBro self-assigned this Oct 17, 2023
@ThatOneBro ThatOneBro added the auth Authentication and authorization features and fixes label Oct 17, 2023
@github-actions
Copy link

github-actions bot commented Oct 17, 2023 •
edited
Loading

Messages
📖 @medplum/core: 136.9 kB
📖 @medplum/react: 188.4 kB

Generated by 🚫 dangerJS against 5754152

codyebberson
codyebberson reviewed Oct 18, 2023
View reviewed changes
Copy link
Member

@codyebberson codyebberson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. See comment on getActiveLogin code path. Feel free to disagree.

@ThatOneBro
Copy link
Member Author

Nice. See comment on getActiveLogin code path. Feel free to disagree.

Nope, that makes sense to me. Shouldn't bother calling it if we provide an accessToken, totally agree.

@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codyebberson codyebberson added this pull request to the merge queue Oct 18, 2023
Merged via the queue into main with commit 74a0e64 Oct 18, 2023
15 checks passed
@codyebberson codyebberson deleted the derrick-fix-access-token-not-respected branch October 18, 2023 03:26
codyebberson added a commit that referenced this pull request Oct 19, 2023
@codyebberson
Release Version 2.1.6
4283594 
Add documentation about resource profiles (#3068)
Use helper function for stringifying OutcomeError message (#3082)
Fixes #3077 - correct valueCoding in QuestionnaireForm (#3079)
Add expression (path) to OutcomeError message display (#3078)
Fixed Typo and Grammer  (#3076)
fix(tesh.sh): add shebang for `test.sh` (#3075)
Add MedicationRequest and README Changes (#3064)
fix(build): put placeholder env vars in build step (#3070)
fix(client/auth): respect `accessToken` in constructor (#3066)
Fixes #3069 - docs import warning (#3072)
Added 'Diagnoses' and 'Billing' to Health Gorilla order form (#3062)
Updating document to 2023 version (#3067)
Updating test plan in relation to #2794 (#3061)
Fixes #3027 - added re operator for _filter (#3060)
Fixes #3057 - set Location header on create (#3059)
Updates to SOAP Note and tasks (#3053)
fix: update location of `QuestionnaireForm.stories.tsx` (#3056)
Update README.md (#3058)
Added DangerJS (#3043)
Reorganize auth docs (#3029)
Add valueset for allergies (#3052)
Fixes #3047 - fix _filter ne operator (#3054)
Fixes #3050 - project admins reading project-scoped users (#3051)
Fixed Typo and Grammar  (#3042)
fix(websocket): handle invalid WS conns gracefully (#3049)
Fixes #3045 - expose require in VM context bots (#3046)
Fixes #2942 - handle observation cycles in DiagnosticReportDisplay (#3044)
Fix react fast refresh warnings (#3041)
Fixes #389 - rename validate to validateResource (#3039)
Dependency upgrades (#3040)
@codyebberson codyebberson mentioned this pull request Oct 19, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 19, 2023
@codyebberson
Release Version 2.1.6 (#3086)
53b4c38 
Add documentation about resource profiles (#3068)
Use helper function for stringifying OutcomeError message (#3082)
Fixes #3077 - correct valueCoding in QuestionnaireForm (#3079)
Add expression (path) to OutcomeError message display (#3078)
Fixed Typo and Grammer  (#3076)
fix(tesh.sh): add shebang for `test.sh` (#3075)
Add MedicationRequest and README Changes (#3064)
fix(build): put placeholder env vars in build step (#3070)
fix(client/auth): respect `accessToken` in constructor (#3066)
Fixes #3069 - docs import warning (#3072)
Added 'Diagnoses' and 'Billing' to Health Gorilla order form (#3062)
Updating document to 2023 version (#3067)
Updating test plan in relation to #2794 (#3061)
Fixes #3027 - added re operator for _filter (#3060)
Fixes #3057 - set Location header on create (#3059)
Updates to SOAP Note and tasks (#3053)
fix: update location of `QuestionnaireForm.stories.tsx` (#3056)
Update README.md (#3058)
Added DangerJS (#3043)
Reorganize auth docs (#3029)
Add valueset for allergies (#3052)
Fixes #3047 - fix _filter ne operator (#3054)
Fixes #3050 - project admins reading project-scoped users (#3051)
Fixed Typo and Grammar  (#3042)
fix(websocket): handle invalid WS conns gracefully (#3049)
Fixes #3045 - expose require in VM context bots (#3046)
Fixes #2942 - handle observation cycles in DiagnosticReportDisplay (#3044)
Fix react fast refresh warnings (#3041)
Fixes #389 - rename validate to validateResource (#3039)
Dependency upgrades (#3040)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyebberson codyebberson codyebberson approved these changes

@mattwiller mattwiller Awaiting requested review from mattwiller

Assignees

@ThatOneBro ThatOneBro

Labels
auth Authentication and authorization features and fixes
Projects
Medplum Product Roadmap
Archived in project
Milestone
November 1, 2023
Development

Successfully merging this pull request may close these issues.

MedplumClient constructor ignores accessToken
3 participants
@ThatOneBro @codyebberson @mattwiller