feat(client): add fhircast{Publish, Subscribe, Connect}
#3024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply Sweep Rules to your PR?
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ThatOneBro
added
subscriptions
codyebberson
approved these changes
Oct 14, 2023
There was a problem hiding this comment.
Nice, lgtm 👍
A couple small things if you want to:
- I think you can replace
satisfies PendingSubscriptionRequest as PendingSubscriptionRequestwith justas PendingSubscriptionRequest - See the Sonar issue on removing
ISOTimestamp: https://sonarcloud.io/project/issues?pullRequest=3024&open=AYshku8gkpT7zR4ZNmCP&id=medplum_medplum
I know it's a little weird to use string for date/times, but we do it all over the place for FHIR compliance. We're not getting much (any?) additional type safety from ISOTimestamp, so I would recommend removing it.
|
Kudos, SonarCloud Quality Gate passed! |
codyebberson
added a commit
that referenced
this pull request
Oct 14, 2023
Fixed version mismatch in package-lock.json
feat(client): add `fhircast{Publish, Subscribe, Connect}` (#3024)
More details in slack message on deploy (#3035)
Client Chart Example (#2999)
Fixes #3032 - send slack message on deploy and publish (#3034)
Fix primitive extensions on choice types (#3033)
Add documentation for representing prescriptions and medication orders (#2807)
Test against multiple Postgres versions (#3026)
Handle search on numeric array columns (#3022)
Health Gorilla order form update (#3023)
Updated compliance logos (#3021)
Merge schema/validation systems (#2859)
feat(server/bullmq): remove all finalized jobs by default (#3014)
Remove barrel files (#3016)
Fixes #2955 - aws lambda client retry policy (#2986)
Filter ClientApplication resources in Apps tab (#3013)
feat(fhircast-demo): add auth story to demo (#2997)
Fixes #2987 Fixes #2988 - use HumanName.text (#2989)
Fixes #2984 - handle invalid UUID in _id search param (#2985)
Update Health Gorilla demo to order multiple tests (#2980)
Fixes #1307 Fixes #2963 Fixes #2969 - binary data docs (#2982)
Gracefully error on invalid JWT in client assertion flow (#2983)
Refresh session profile if not present in client (#2978)
replacing bookmark name string #2979 (#2981)
Limit SQL subqueries for existence checking (#2976)
QuestionnaireForm style tweaks (#2975)
DiagnosticReportDisplay - only show specimen data if present (#2974)
Add `FHIRcast` client example (#2965)
Fixes #2971 - update Questionnaire reference inputs (#2973)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 15, 2023
* Fixed version mismatch in package-lock.json
* Release Version 2.1.5
Fixed version mismatch in package-lock.json
feat(client): add `fhircast{Publish, Subscribe, Connect}` (#3024)
More details in slack message on deploy (#3035)
Client Chart Example (#2999)
Fixes #3032 - send slack message on deploy and publish (#3034)
Fix primitive extensions on choice types (#3033)
Add documentation for representing prescriptions and medication orders (#2807)
Test against multiple Postgres versions (#3026)
Handle search on numeric array columns (#3022)
Health Gorilla order form update (#3023)
Updated compliance logos (#3021)
Merge schema/validation systems (#2859)
feat(server/bullmq): remove all finalized jobs by default (#3014)
Remove barrel files (#3016)
Fixes #2955 - aws lambda client retry policy (#2986)
Filter ClientApplication resources in Apps tab (#3013)
feat(fhircast-demo): add auth story to demo (#2997)
Fixes #2987 Fixes #2988 - use HumanName.text (#2989)
Fixes #2984 - handle invalid UUID in _id search param (#2985)
Update Health Gorilla demo to order multiple tests (#2980)
Fixes #1307 Fixes #2963 Fixes #2969 - binary data docs (#2982)
Gracefully error on invalid JWT in client assertion flow (#2983)
Refresh session profile if not present in client (#2978)
replacing bookmark name string #2979 (#2981)
Limit SQL subqueries for existence checking (#2976)
QuestionnaireForm style tweaks (#2975)
DiagnosticReportDisplay - only show specimen data if present (#2974)
Add `FHIRcast` client example (#2965)
Fixes #2971 - update Questionnaire reference inputs (#2973)
* Fixed cyclonedx dep
* Fixed merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
fhircastSubscribe()toMedplumClientto subscribe to a topicfhircastUnsubscribe()toMedplumClientto unsubscribe from a topicfhircastConnect()toMedplumClientto connect to a topic's WebSocket endpointfhircastPublish()toMedplumClientfor publishers to publish events to a topicFhircastConnectionclass for managing aFHIRcastWebSocket connectioncore/src/fhircastuseState<T | undefined>, which for complex types can lead to a@typescript-eslinterror (https://typescript-eslint.io/rules/no-redundant-type-constituents/)fhircastPublishandfhircastSubscribetoMedplumClient#2998TODO:
createFhircastMessagePayload()fhircastSubscribe()fhircastConnect()fhircastPublish()fhircastUnsubscribe()crypto.randomUUID()to work injest-jsdom-environment