Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fhircast-demo): add auth story to demo #2997

Merged
merged 27 commits into from
Oct 9, 2023

Conversation

ThatOneBro
Copy link
Member

What this PR does

  • Adds auth story to FHIRcast demo at examples/medplum-fhircast-demo
  • Refactors the demo to use Mantine components and AppShell
  • Adds searchDisabled and resourceNavigatorDisabled to AppShell component (along with storybook examples)
  • Closes Add auth story to FHIRcast demo #2977

@ThatOneBro ThatOneBro requested a review from a team as a code owner October 6, 2023 23:43
@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
medplum-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2023 3:43pm
medplum-www ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2023 3:43pm

@coveralls
Copy link

coveralls commented Oct 7, 2023

Coverage Status

coverage: 94.054% (+0.002%) from 94.052% when pulling 2d8fc35 on derrick-add-auth-fhircast-demo into 7bf1cc9 on main.

Copy link
Member

@codyebberson codyebberson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This turned out really clean!

A few minor suggestions, nothing major.

packages/react/src/AppShell/AppShell.tsx Outdated Show resolved Hide resolved
packages/react/src/AppShell/AppShell.tsx Outdated Show resolved Hide resolved
packages/react/src/AppShell/AppShell.tsx Outdated Show resolved Hide resolved
packages/react/src/AppShell/AppShell.tsx Outdated Show resolved Hide resolved
packages/react/src/AppShell/Header.tsx Outdated Show resolved Hide resolved
packages/react/src/AppShell/Navbar.tsx Outdated Show resolved Hide resolved
packages/server/src/fhircast/routes.test.ts Outdated Show resolved Hide resolved
packages/server/src/fhircast/routes.ts Outdated Show resolved Hide resolved
@ThatOneBro ThatOneBro self-assigned this Oct 9, 2023
@ThatOneBro ThatOneBro added this to the November 1, 2023 milestone Oct 9, 2023
packages/server/src/fhircast/routes.ts Dismissed Show dismissed Hide dismissed
@sonarcloud
Copy link

sonarcloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@codyebberson codyebberson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ship it

@ThatOneBro ThatOneBro added this pull request to the merge queue Oct 9, 2023
Merged via the queue into main with commit 3f32be5 Oct 9, 2023
12 checks passed
@ThatOneBro ThatOneBro deleted the derrick-add-auth-fhircast-demo branch October 9, 2023 20:41
codyebberson added a commit that referenced this pull request Oct 14, 2023
Fixed version mismatch in package-lock.json
feat(client): add `fhircast{Publish, Subscribe, Connect}` (#3024)
More details in slack message on deploy (#3035)
Client Chart Example (#2999)
Fixes #3032 - send slack message on deploy and publish (#3034)
Fix primitive extensions on choice types (#3033)
Add documentation for representing prescriptions and medication orders (#2807)
Test against multiple Postgres versions (#3026)
Handle search on numeric array columns (#3022)
Health Gorilla order form update (#3023)
Updated compliance logos (#3021)
Merge schema/validation systems (#2859)
feat(server/bullmq): remove all finalized jobs by default (#3014)
Remove barrel files (#3016)
Fixes #2955 - aws lambda client retry policy (#2986)
Filter ClientApplication resources in Apps tab (#3013)
feat(fhircast-demo): add auth story to demo (#2997)
Fixes #2987 Fixes #2988 - use HumanName.text (#2989)
Fixes #2984 - handle invalid UUID in _id search param (#2985)
Update Health Gorilla demo to order multiple tests (#2980)
Fixes #1307 Fixes #2963 Fixes #2969 - binary data docs (#2982)
Gracefully error on invalid JWT in client assertion flow (#2983)
Refresh session profile if not present in client (#2978)
replacing bookmark name string #2979 (#2981)
Limit SQL subqueries for existence checking (#2976)
QuestionnaireForm style tweaks (#2975)
DiagnosticReportDisplay - only show specimen data if present (#2974)
Add `FHIRcast` client example (#2965)
Fixes #2971 - update Questionnaire reference inputs (#2973)
github-merge-queue bot pushed a commit that referenced this pull request Oct 15, 2023
* Fixed version mismatch in package-lock.json

* Release Version 2.1.5

Fixed version mismatch in package-lock.json
feat(client): add `fhircast{Publish, Subscribe, Connect}` (#3024)
More details in slack message on deploy (#3035)
Client Chart Example (#2999)
Fixes #3032 - send slack message on deploy and publish (#3034)
Fix primitive extensions on choice types (#3033)
Add documentation for representing prescriptions and medication orders (#2807)
Test against multiple Postgres versions (#3026)
Handle search on numeric array columns (#3022)
Health Gorilla order form update (#3023)
Updated compliance logos (#3021)
Merge schema/validation systems (#2859)
feat(server/bullmq): remove all finalized jobs by default (#3014)
Remove barrel files (#3016)
Fixes #2955 - aws lambda client retry policy (#2986)
Filter ClientApplication resources in Apps tab (#3013)
feat(fhircast-demo): add auth story to demo (#2997)
Fixes #2987 Fixes #2988 - use HumanName.text (#2989)
Fixes #2984 - handle invalid UUID in _id search param (#2985)
Update Health Gorilla demo to order multiple tests (#2980)
Fixes #1307 Fixes #2963 Fixes #2969 - binary data docs (#2982)
Gracefully error on invalid JWT in client assertion flow (#2983)
Refresh session profile if not present in client (#2978)
replacing bookmark name string #2979 (#2981)
Limit SQL subqueries for existence checking (#2976)
QuestionnaireForm style tweaks (#2975)
DiagnosticReportDisplay - only show specimen data if present (#2974)
Add `FHIRcast` client example (#2965)
Fixes #2971 - update Questionnaire reference inputs (#2973)

* Fixed cyclonedx dep

* Fixed merge conflict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add auth story to FHIRcast demo
3 participants