New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate CPU and memory options in CLI `aws init` command #2880

Open

codyebberson opened this issue Sep 19, 2023 · 0 comments

Labels

Milestone

Milestone Quality

Member

codyebberson commented Sep 19, 2023 •

edited

Loading

Currently, we prompt the user for CPU and memory options independently.

AWS does not support all options independently - only certain pairs are valid:

https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task_definition_parameters.html#task_size

We should either validate the pairs, or present them to the user as pairs in the first place.

Here is where we currently prompt the user:

https://github.com/medplum/medplum/blob/main/packages/cli/src/aws/init.ts#L174-L189

We should also update the default values:

512 MiB is prone to crashing on OOM
0.5 vCPU and 1.0 memory might be better defaults

reshmakh added the self-host label

rahul1 added this to the Milestone Quality milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment