Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#9229): old action bar prevents editing home places #9230

Merged
merged 3 commits into from
Jul 2, 2024
Merged

fix(#9229): old action bar prevents editing home places #9230

merged 3 commits into from
Jul 2, 2024

Conversation

latin-panda
Copy link
Contributor

@latin-panda latin-panda commented Jul 1, 2024 •
edited by github-actions bot
Loading

Description

#9229

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@latin-panda latin-panda linked an issue Jul 1, 2024 that may be closed by this pull request
Old action bar should prevent users with multiple facilities assigned from editing the homeplace #9229
Closed
Benmuiruri
Benmuiruri approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@Benmuiruri Benmuiruri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@latin-panda
Copy link
Contributor Author

Tests:

User assigned to 1 facility

Edit enabled for other places (no homeplace)

Screenshot 2024-07-02 at 9 39 07 AM

Edit disabled for homeplace

Screenshot 2024-07-02 at 9 28 33 AM

User assigned to 1 facility - backward compatibility

Edit enabled for other places (no homeplace)

Screenshot 2024-07-02 at 9 37 30 AM

Edit disabled for homeplace

Screenshot 2024-07-02 at 9 36 21 AM

User assigned to 2 facilities -

Edit enabled for other places (no homeplace)

Screenshot 2024-07-02 at 9 40 46 AM

Edit disabled for homeplace

Screenshot 2024-07-02 at 9 32 27 AM

@latin-panda latin-panda merged commit 9f90022 into master Jul 2, 2024
44 checks passed
@latin-panda latin-panda deleted the avoid-editing-homeplace branch July 2, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benmuiruri Benmuiruri Benmuiruri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Old action bar should prevent users with multiple facilities assigned from editing the homeplace
2 participants
@latin-panda @Benmuiruri