New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we're always logging stacktraces #4522

Closed

SCdF opened this issue May 4, 2018 · 0 comments

Labels

Won't fix: Ancient

Contributor

SCdF commented May 4, 2018

We need to go through all of our code that logs errors, and make sure we're passing the raw error to console.error.

e.g.

// bad
console.error(`oh no ${err} occurred`);

// good
console.error(`oh no ${err} occurred`, err);

If we don't do this we lose stacktraces, which we almost always want

garethbowen added the Won't fix: Ancient label

garethbowen closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment