Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defined constants for LEFT and RIGHT #42

Merged
merged 6 commits into from
Jan 5, 2022
Merged

Conversation

JustinSGray
Copy link
Contributor

Purpose

left and right would be better as module level constants, making the IDE more effective.

Type of change

Addition of constants

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

No new tests needed, but existing tests were updated to use the constants to verify functionality

Checklist

(note: not enforcing line number restriction on this codebase)

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@JustinSGray JustinSGray requested a review from a team as a code owner January 5, 2022 15:50
@JustinSGray JustinSGray requested a review from ewu63 January 5, 2022 15:50
ewu63
ewu63 previously approved these changes Jan 5, 2022
Copy link
Collaborator

@ewu63 ewu63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look okay. Longer term, I would like to change these (and all the OPT etc.) to enums, but that doesn't have to happen in this PR.

@ewu63
Copy link
Collaborator

ewu63 commented Jan 5, 2022

We decided to get this in and make a release first, before making the (potentially backwards incompatible) changes.

@ewu63 ewu63 merged commit 259f56a into mdolab:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants