Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pong): fix invalid default value #11384

Merged
merged 1 commit into from
Jul 1, 2024
Merged

fix(pong): fix invalid default value #11384

merged 1 commit into from
Jul 1, 2024

Conversation

fiji-flo
Copy link
Contributor

@fiji-flo fiji-flo commented Jul 1, 2024

Summary

Don't default to an object for the heading (shouldn't have been there in the first place).

Problem

This causes a blank page when cta was set. Which it shouldn't be.

@fiji-flo fiji-flo requested a review from a team as a code owner July 1, 2024 10:38
@fiji-flo fiji-flo merged commit 1ad0e5a into main Jul 1, 2024
14 checks passed
@fiji-flo fiji-flo deleted the fix-new-pong-2 branch July 1, 2024 10:46
ferdnyc pushed a commit to ferdnyc/yari that referenced this pull request Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants