Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ndp: add PREF64 support #31

Merged
merged 1 commit into from
Mar 12, 2024
Merged

ndp: add PREF64 support #31

merged 1 commit into from
Mar 12, 2024

Conversation

jmbaur
Copy link
Contributor

@jmbaur jmbaur commented Mar 9, 2024

This change brings PREF64 support as specified in RFC 8781.

option_test.go Outdated Show resolved Hide resolved
option.go Outdated Show resolved Hide resolved
option.go Outdated Show resolved Hide resolved
option.go Outdated Show resolved Hide resolved
option.go Outdated Show resolved Hide resolved
option.go Outdated Show resolved Hide resolved
@jmbaur jmbaur force-pushed the pref64 branch 3 times, most recently from 3e2fa00 to 0641f49 Compare March 12, 2024 03:30
Copy link
Owner

@mdlayher mdlayher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@mdlayher
Copy link
Owner

You can ignore the CI failure, I'll update to Go 1.21/1.22 in another branch.

Would you mind adding tests for /40, 48, 56, 64? I notice those are missing in coverage in a local checkout.

@mdlayher
Copy link
Owner

Please rebase on main thanks!

This change brings PREF64 support as specified in RFC 8781.
Copy link
Owner

@mdlayher mdlayher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@mdlayher mdlayher merged commit 2971198 into mdlayher:main Mar 12, 2024
3 checks passed
@mdlayher
Copy link
Owner

I'll tag a new release too.

@jmbaur jmbaur deleted the pref64 branch March 12, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants