Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FontAwesome icons do not load for some users #12

Closed
mbuscemi opened this issue Jan 3, 2018 · 5 comments
Closed

FontAwesome icons do not load for some users #12

mbuscemi opened this issue Jan 3, 2018 · 5 comments
Assignees
Labels
Milestone

Comments

@mbuscemi
Copy link
Owner

mbuscemi commented Jan 3, 2018

Failed to load resource: net::ERR_FILE_NOT_FOUND
fontawesome-webfont.woff2, fontawesome-webfont.woff, fontawesome-webfont.ttf
reported by @halohalospecial

@mbuscemi
Copy link
Owner Author

mbuscemi commented Jan 4, 2018

Some good progress here. With the help of the Atom console, I've discovered that my fontawesome font files are actually loading from atom:https://file-icons/fonts/ and not from atom:https://elm-lens/resources. It appears that registration of that internal Atom URL is not automatic.

@mbuscemi
Copy link
Owner Author

mbuscemi commented Jan 4, 2018

The default FontAwesome installation has a version number appended to the font URLs, presumably for caching optimization. This was thwarting Atom's ability to use the URL properly. I stripped those out of the URLs and was then able to load Elm Lens's version of the font files.

Fix coming 0.3.0.

@mbuscemi mbuscemi added this to the 0.3.0 milestone Jan 4, 2018
@mbuscemi
Copy link
Owner Author

Should be fixed in 0.3. @halohalospecial, please let me know if you're still experiencing this.

@halohalospecial
Copy link

Thanks for the fix! It's already working 🎉

@mbuscemi
Copy link
Owner Author

Awesome! I'm glad it's working for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants