From f87879cc83008f837c680d5742eeb35622a2436f Mon Sep 17 00:00:00 2001 From: Piotr Nowojski Date: Thu, 23 Jan 2020 13:02:16 +0100 Subject: [PATCH] [hotfix][rest] Remove redundant comments in SubtaskStateStats --- .../runtime/checkpoint/SubtaskStateStats.java | 46 ++++--------------- 1 file changed, 8 insertions(+), 38 deletions(-) diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/SubtaskStateStats.java b/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/SubtaskStateStats.java index ee9e287edf8c9..829c277f8a826 100644 --- a/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/SubtaskStateStats.java +++ b/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/SubtaskStateStats.java @@ -36,7 +36,6 @@ public class SubtaskStateStats implements Serializable { private static final long serialVersionUID = 8928594531621862214L; - /** Index of this sub task. */ private final int subtaskIndex; /** @@ -60,17 +59,6 @@ public class SubtaskStateStats implements Serializable { /** Alignment duration in . */ private final long alignmentDuration; - /** - * Creates the stats for a single subtask. - * - * @param subtaskIndex Index of the subtask. - * @param ackTimestamp Timestamp when the acknowledgement of this subtask was received at the coordinator. - * @param stateSize Size of the checkpointed state at this subtask. - * @param syncCheckpointDuration Checkpoint duration at the task (synchronous part) - * @param asyncCheckpointDuration Checkpoint duration at the task (asynchronous part) - * @param alignmentBuffered Bytes buffered during stream alignment (for exactly-once only). - * @param alignmentDuration Duration of the stream alignment (for exactly-once only). - */ SubtaskStateStats( int subtaskIndex, long ackTimestamp, @@ -91,11 +79,6 @@ public class SubtaskStateStats implements Serializable { this.alignmentDuration = alignmentDuration; } - /** - * Returns the subtask index. - * - * @return Subtask index. - */ public int getSubtaskIndex() { return subtaskIndex; } @@ -133,45 +116,32 @@ public long getEndToEndDuration(long triggerTimestamp) { } /** - * Returns the duration of the synchronous part of the checkpoint. - * - *

Can return -1 if the runtime did not report this. - * - * @return Duration of the synchronous part of the checkpoint or -1. + * @return Duration of the synchronous part of the checkpoint or -1 if the runtime + * did not report this. */ public long getSyncCheckpointDuration() { return syncCheckpointDuration; } /** - * Returns the duration of the asynchronous part of the checkpoint. - * - *

Can return -1 if the runtime did not report this. - * - * @return Duration of the asynchronous part of the checkpoint or -1. + * @return Duration of the asynchronous part of the checkpoint or -1 if the runtime + * did not report this. */ public long getAsyncCheckpointDuration() { return asyncCheckpointDuration; } /** - * Returns the number of bytes buffered during stream alignment (for - * exactly-once only). - * - *

Can return -1 if the runtime did not report this. - * - * @return Number of bytes buffered during stream alignment or -1. + * @return Number of bytes buffered during stream alignment (for exactly-once only) or + * -1 if the runtime did not report this. */ public long getAlignmentBuffered() { return alignmentBuffered; } /** - * Returns the duration of the stream alignment (for exactly-once only). - * - *

Can return -1 if the runtime did not report this. - * - * @return Duration of the stream alignment or -1. + * @return Duration of the stream alignment (for exactly-once only) or -1 if the + * runtime did not report this. */ public long getAlignmentDuration() { return alignmentDuration;