Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return OOB accuracy #16

Closed
markgrujic opened this issue Dec 19, 2018 · 5 comments
Closed

Return OOB accuracy #16

markgrujic opened this issue Dec 19, 2018 · 5 comments

Comments

@markgrujic
Copy link

Hi,
Thanks for the work on this package. I can't open a branch to submit a PR, but what do you think of the changes here:
https://gist.github.com/markgrujic/a46a4466b618164e77e0abda14d97590

Note a new argument called returnOOB and the associated code from line 80 that returns a list of the imputed data and OOB accuracy if required.
Cheers

@mayer79
Copy link
Owner

mayer79 commented Dec 20, 2018

Thx Mark. I will add it very soon. One question: Would it be an option to add the OOB accuracies as an attribute to the data (so that the standard output interface does not change)? I am not yet sure which is more useful.

@markgrujic
Copy link
Author

Hi, yep attribute would be a great way to do it too. Either way, I'm not fussed.

@mayer79
Copy link
Owner

mayer79 commented Dec 21, 2018

CRAN submission is closed until January 2, but until then you can try to install from github:

library(devtools)
install_github("mayer79/missRanger/release/missRanger")

library(missRanger)
irisWithNA <- generateNA(iris)
irisImputed <- missRanger(irisWithNA, pmm.k = 3, returnOOB = TRUE)
attr(irisImputed, "oob")

#      Species Petal.Length Sepal.Length  Petal.Width  Sepal.Width 
# 0.000000000  0.005397051  0.019491343  0.008372170  0.052749390 

@markgrujic
Copy link
Author

Great, works a treat. Sorry for the delay, end of year etc..
Cheers

@mayer79
Copy link
Owner

mayer79 commented Jan 8, 2019

Now on CRAN

@mayer79 mayer79 closed this as completed Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants