-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localization: consider using platform resources #107
Labels
enhancement
New feature or request
Comments
You are right, I removed the existing sheets_ok and sheets_cancel strings and replaced with them with the android string resource. Probably didn't think of it at the beginning. Thanks! |
maxkeppeler
added a commit
that referenced
this issue
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Not a bug, just a suggestion.
I think You should consider using android.R.string.ok and android.R.string.cancel for positive/negative buttons so You don't have to deal with translations.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: