Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for event emit instead of flipKey #35

Open
scratchmex opened this issue Jan 14, 2021 · 1 comment
Open

add support for event emit instead of flipKey #35

scratchmex opened this issue Jan 14, 2021 · 1 comment

Comments

@scratchmex
Copy link

scratchmex commented Jan 14, 2021

Maybe add support to force a refresh when emiting certain event instead of the component watching for the flipKey prop. I think this is more suitable for complex scenarios like large list or various components. At first I got trouble understanding the flipKey and I said, why we don't just give it a boolean and flip the value when we want it to refresh it!? but then I realized it will be more readable to support some emit('refresh'). I will be happy to start working on a PR draft but I want to start a discussion as well.

@mattrothenberg
Copy link
Owner

I don't think I understand the use case of this proposed imperative API.

Why can't you modify the value of flipKey to trigger an animation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants