Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reactions:write to user scopes #696

Merged
merged 3 commits into from
Aug 8, 2022
Merged

Add reactions:write to user scopes #696

merged 3 commits into from
Aug 8, 2022

Conversation

Half-Shot
Copy link
Contributor

No description provided.

@Half-Shot Half-Shot requested a review from a team as a code owner July 29, 2022 13:34
tadzik
tadzik approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@tadzik tadzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, but what is it actually changing?

@Half-Shot
Copy link
Contributor Author

Failing to ask for this in previous releases meant we weren't allowing Matrix users to react on Slack (which the upstream ansible-deploy was correcting us on https://github.com/spantaleev/matrix-docker-ansible-deploy/blob/master/docs/configuring-playbook-bridge-appservice-slack.md)

@Half-Shot Half-Shot merged commit 02d560f into develop Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadzik tadzik tadzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @tadzik