fix: fix setext heading interupts #3210
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| <p>fenced code block</p> | ||
| <pre><code>= | ||
| </code></pre> | ||
| <blockquote><h1>blockquote</h1> |
There was a problem hiding this comment.
The <h1> here doesn't match what I'm seeing in Commonmark. Should be <p> instead.
There was a problem hiding this comment.
hmm ya it looks like common mark treats blockquote differently based on if it has a > at the beginning of the line.
The spec says the block quote will continue without lines starting with > only if the content is paragraph continuation text. And it gives Example 234 as an example of not continuing the block quote.
In this case the = would not be paragraph continuation text since it indicates a setext heading without the content above being a blockquote.
There was a problem hiding this comment.
Looks like commonmark/commonmark-spec#539 seems to say it is paragraph continuation text simply because common mark says so.
This is one of those rules where the common mark spec states how commonmark works, not how markdown should work. 😕
This is how marked works currently anyway so it isn't a regression.
I will create an L2 bug for this but I don't think it should block this PR.
## [12.0.1](v12.0.0...v12.0.1) (2024-03-06) ### Bug Fixes * fix setext heading interupts ([#3210](#3210)) ([d848445](d848445))
Marked version: 12.0.0
Description
setext spec
Setext heading should not follow list item, code block, block quote, ATX heading, or HTML block.
Contributor
Committer
In most cases, this should be a different person than the contributor.