Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Ability to "Kill" container #267

Open
jeffijoe opened this issue Jul 6, 2022 · 1 comment
Open

[Feature Request] Ability to "Kill" container #267

jeffijoe opened this issue Jul 6, 2022 · 1 comment
Assignees
Milestone

Comments

@jeffijoe
Copy link

jeffijoe commented Jul 6, 2022

Loving this library, fantastic work!

I was wondering if it would be possible to introduce a .Kill() on IContainerService that would use docker kill?

When tearing down an integration test, we usually don't want to wait for the container to gracefully exit, since they are disposable anyway. Some images like Google's PubSub emulator in the image gcr.io/google.com/cloudsdktool/cloud-sdk:emulators seems to ignore the SIGTERM and so it'll take an extra 10 seconds for .Stop() to finish.

@mariotoffia
Copy link
Owner

This is an excellent idea! I'll add it to my todo list!

Cheers,
Mario :)

@mariotoffia mariotoffia self-assigned this Jul 8, 2022
@mariotoffia mariotoffia added this to the 3.0.0-RELEASE milestone Jul 8, 2022
@mariotoffia mariotoffia added this to To do in FluentDocker via automation Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
FluentDocker
  
To do
Development

No branches or pull requests

2 participants